Skip to content

Bring clippy into ci for cleaner code #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xizheyin opened this issue Apr 22, 2025 · 2 comments
Open

Bring clippy into ci for cleaner code #1950

xizheyin opened this issue Apr 22, 2025 · 2 comments

Comments

@xizheyin
Copy link
Contributor

I was modifying the code and realized that there are a lot of places where style could be improved, I scanned it with clippy and found a very large number of warnings. is there a need to bring clippy into CI?

@apiraino
Copy link
Contributor

Someone already sent a while ago a patch to fix clippy lints #1758

IMHO (I am not a maintainer of this repo) I think the first wave of fixes should be manual and carefully reviewed because things may break. Also we probably don't want to apply blindly any clippy lint.

@xizheyin
Copy link
Contributor Author

Make sense, and it would be better if each lint was divided into different commits. I do think there is a need to do some of that. For example, I had some unused code in my PR submission that would not be detected, and I discovered this manually. I don't know if it's a problem with rust-analyzer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants