Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VhostUserSlaveReqHandler::set_slave_req_fd() to take an UnixStream instead of SlaveFsCacheReq #99

Open
jiangliu opened this issue Dec 19, 2021 · 2 comments

Comments

@jiangliu
Copy link
Member

Currently VhostUserSlaveReqHandler::set_slave_req_fd() accepts an SlaveFsCacheReq input parameter, that means the slave communication channel could only used to support virtio-fs map/unmap requests.
It should take an UnixStream as input, so the backend implementation makes the decision what service will be supported on the slave communication channel.

@jiangliu
Copy link
Member Author

@slp @sboeuf This will be a breaking change, any suggestions?

@sboeuf
Copy link
Collaborator

sboeuf commented Dec 20, 2021

Since this is a proposal to make the code more generic, I'm totally okay with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants