Should we move test utils contracts under src?

[andreivladbrg]

As discussed in this PR: sablier-labs/evm-utils#8,

Inspired by Uniswap’s v4-core repo, should we move the test utils from the tests repo to src/tests/?
We are making this change in evm-utils, so I believe it makes total sense to do it here as well.

@sablier-labs/evm

[PaulRBerg]

Yep

[smol-ninja]

I am in soft agreement but we should think more on this. Because it's not as straightforward as it was in evm-utils.

└── utils
    ├── ArrayBuilder.sol
    ├── Assertions.sol
    ├── BaseScript.t.sol
    ├── BatchLockupBuilder.sol
    ├── Calculations.sol
    ├── Defaults.sol
    ├── DeployOptimized.t.sol
    ├── EstimateMaxCount.sol
    ├── Fuzzers.sol
    ├── Modifiers.sol
    ├── Types.sol
    └── Utils.sol

Types, Modifiers, Defaults, Constants (in future) do not seem to be good candidates for src/test because they contain test variables, modifiers, structs and similar code.

Uniswap also has a utils directory in their tests folder as can be seen here. So it seems to me that they have given a good thought to it while deciding what to keep in tests/utils and what to keep in src/test.

I also noticed that all files in src/test are contracts whereas all most files in test/utils are libraries. They also have a Constants file in test/utils but its marked as library.

May be thats the difference, libraries. I haven’t understood the actual reasoning behind it though.

[PaulRBerg]

I'll let you figure it out! No strong opinion.

[PaulRBerg]

Any update on this @sablier-labs/evm?

[andreivladbrg]

no update, we didn't implement it or decide to do so

closing as not a priority