Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning & from a tracked function #610

Open
nikomatsakis opened this issue Oct 28, 2024 · 0 comments
Open

Returning & from a tracked function #610

nikomatsakis opened this issue Oct 28, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@nikomatsakis
Copy link
Member

I noticed that code like

#[salsa::input]
struct Input {
    #[return_ref]
    data: Vec<String>
}

#[salsa::tracked]
fn test<'db>(db: &'db dyn crate::Database, input: Input) -> &'db String {
    input.data(db).first().unwrap()
}

...will compile, but I don't think that's sound. We should be requiring the Update trait on the return value.

Filing this issue so I don't forget to think about it. =)

@nikomatsakis nikomatsakis added this to the Salsa 3.0 milestone Oct 28, 2024
@nikomatsakis nikomatsakis added the bug Something isn't working label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant