refactoring

Author: samayun

app/Http/Controllers/Admin/ProductController.php

@@ -153,11 +153,12 @@ public function deleteProductAttribute($productAttributeId)
      */
     public function destroy(Product $product)
     {
+        $deletedData = $this->productRepository->delete($product->id);
         $path = 'products/'.$product->image;
         if (Storage::disk('public')->exists($path)) {
             Storage::disk('public')->delete($path);
-         }
-        return $this->productRepository->delete($product->id);
+        }
+        return $deletedData;
     }
 
     public function bulk_delete(Request $request){

app/Repositories/ProductRepository.php

@@ -125,15 +125,17 @@ public function delete(int $id){
     public function bulk_delete($selected_data)
     {
         $this->flush($this->CACHE_KEY);
+        DB::beginTransaction();
         foreach ($selected_data as $product) {
             $found = $this->findById($product['id']);
             $path = 'products/'.$found['image'];
+
             if (Storage::disk('public')->exists($path)) {
                 Storage::disk('public')->delete($path);
             }
-            DB::beginTransaction();
             $found->delete();
-            DB::commit();
         }
+        DB::commit();
+        // success
     }
 }