Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis auth support #1453

Closed
laoshancun opened this issue Dec 28, 2017 · 5 comments
Closed

redis auth support #1453

laoshancun opened this issue Dec 28, 2017 · 5 comments
Labels

Comments

@laoshancun
Copy link

hi.
how to pass redis password to gitlab?

@drubin
Copy link
Contributor

drubin commented Dec 29, 2017

It doesn't currently seem to be possible.

The config file https://github.com/sameersbn/docker-gitlab/blob/master/assets/runtime/config/gitlabhq/resque.yml#L17

The redis checks https://github.com/sameersbn/docker-gitlab/blob/master/assets/runtime/functions#L248

Originally I thought you could hack REDIS_HOST to embed the user:pass but because of the checks that won't work.

It would be a nice feature for Redis nodes that are not running on the machine to support REDIS_URI configuration option and create the uri and connect via the -u option but that was only added in 3.2.1 and the redis-cli version bundled with this version is 2.8.4

@drubin
Copy link
Contributor

drubin commented Dec 29, 2017

there is also a pretty old PR for this #1026

@laoshancun
Copy link
Author

how about merge #1026 to master? @sameersbn

@phenomax
Copy link
Contributor

phenomax commented Jan 5, 2018

I'd also look forward to this! ping @solidnerd

@stale
Copy link

stale bot commented May 7, 2020

This issue has been automatically marked as stale because it has not had any activity for the last 60 days. It will be closed if no further activity occurs during the next 7 days. Thank you for your contributions.

@stale stale bot added the wontfix label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants