Inconsistency with "Update project" and "Refactor this"

[svenjacobs]

I noticed an inconsistency with the binding of "Update project". On macOS it's bound to Cmd+T, however with this keymap it's Ctrl+Alt+Shift+T. Shouldn't it be Ctrl+T, which however is bound to "Refactor this"? On macOS "Refactor this" is actually Ctrl+T so this might be the reason? Can this even be solved?

[samvtran]

Hey Sven, thanks for reaching out about this. It's definitely a tricky problem, but I did finally figure out what happened that caused this little conundrum.

The actual keymap XML files that JetBrains ships usually don't define the Vcs.UpdateProject, and for the handful that do, it's to unbind the keybinding altogether. What JetBrains actually did was define control T as the default binding as part of the built-in VCS plugin. When the default keymap is loaded on macOS, it uses a special MacOSDefaultKeymap subclass that, among other things, remaps control to command, so the default Control-T binding turns into Command-T.

So what happened was that I started from the XML keymaps and prioritized the macOS keymap's Refactor This... Control-T binding. When that conflicted with the Update Project binding in the default keymap, I then added on additional modifiers to the latter since it technically wasn't part of the macOS or default keymap XML files.

The fact that the Command-T binding is actually derived from Control-T in the default keymap is a good argument for switching it around the way you suggest though. I've been meaning to give the keymap a more thorough audit, so I'll add this to the list of things to look into/fix in the next few weeks. I'll keep you posted!

[svenjacobs]

Hey Sam, thanks for the detailed explanation 🤯 Seems to be quite tricky. I wasn't aware that it's coming from the bundled VCS plugin, though I have been using Cmd+T for many years now 😉