244 feature add signature input in create form template flow #272
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -0,0 +1,11 @@ | |||
| /* | |||
| Warnings: | |||
There was a problem hiding this comment.
We shouldn't have to make a new migration - i would delete this folder. I think this comes from running yarn prisma migrate dev, which automatically generates a new migration. I think yarn prisma migrate reset to run the migrations + seedings should be fine
| @@ -133,6 +134,24 @@ export const FormEditor = ({ | |||
| } | |||
| }; | |||
|
|
|||
| const handleSetSignature = () => { | |||
| const newFieldId = uuidv4(); | |||
There was a problem hiding this comment.
This logic is valid, I would create a new component other than DraggableText to represent signatures, especially with the new designs for signature boxes: https://www.figma.com/design/xTNJRHyohsIf714Ba1eWFY/Hi-fi-Wireframes?node-id=5741-1908&m=dev
| @@ -233,6 +252,23 @@ export const FormEditor = ({ | |||
| > | |||
| <div>{TextIcon}</div> | |||
| </Button> | |||
|
|
|||
| <Button | |||
There was a problem hiding this comment.
Selecting this should disable the text box input and make the background of the signature button darker. Not sure if I'm looking at it wrong, but the screenshots look off, as the Text button is still selected.
There was a problem hiding this comment.
Left some comments in the PR.
A few more things to add:
- We shouldn't have a package-lock.json - this only happens if you use npm install install of yarn install I believe
- There have been a good amount of updates since this PR went up (my bad) but I would pull from main and resolve any merge conflicts before updating the PR
- A good example to look at would be Donny's PR adding checkboxes: Added checkbox and delete functionality #298
Description
Motivation and Context
Allows users creating a form template should be able to add signature input onto the PDF for a specific signature group
Closes #244
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: