Skip to content

"User" definition in domain model is unnecessary #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
goncalvesp opened this issue Aug 7, 2024 · 2 comments
Closed

"User" definition in domain model is unnecessary #905

goncalvesp opened this issue Aug 7, 2024 · 2 comments
Assignees

Comments

@goncalvesp
Copy link

Minor change in the "Add a domain model" step, where a "User" definition is added, seemingly unnecessarily.
Apologies if this seems pedantic, it's just that it raised questions with several colleagues at my company currently going through this training.

image

Line of code: https://github.com/sap-tutorials/btp-dev-guidance/blob/aa1e44d6eb7628de1b1f6cb2f31d0b53eb6acdbe/tutorials/build-cap-app/build-cap-app.md?plain=1#L86C3-L86C79

@slavipande slavipande self-assigned this Aug 8, 2024
@slavipande
Copy link
Member

Hi @goncalvesp,

Thanks for your feedback!

I'll take this for discussion with my dev colleagues and get back to you ASAP.

Best regards,
Sveto

@slavipande
Copy link
Member

@goncalvesp This has been fixed some time ago. Here's how the schema.cds file looks now: https://developers.sap.com/tutorials/build-cap-app.html#77ed3d8d-8aa1-4bc9-8ca2-c6f9ccc823be.

Hence, I'll be closing this issue.
Please let us know if you have any other questions.

Best regards,
Sveto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants