[Private Config] Implement the deprecation (#2631)

See sass/sass#4034

Author: nex3

CHANGELOG.md

@@ -1,4 +1,4 @@
-## 1.92.0-dev
+## 1.92.0
 
 * **Breaking change:** Emit declarations, childless at-rules, and comments in
   the order they appear in the source even when they're interleaved with nested
@@ -9,6 +9,11 @@
   `type` will produce errors, while function calls will be parsed as special
   function strings.
 
+* Configuring private variables using `@use ... with`, `@forward ... with`, and
+  `meta.load-css(..., $with: ...)` is now deprecated. Private variables were
+  always intended to be fully encapsulated within the module that defines them,
+  and this helps enforce that encapsulation.
+
 * Fix a bug where `@extend` rules loaded through a mixture of `@import` and
   `@use` rules could fail to apply correctly.
 

lib/src/deprecation.dart

@@ -15,7 +15,7 @@ enum Deprecation {
   // DO NOT EDIT. This section was generated from the language repo.
   // See tool/grind/generate_deprecations.dart for details.
   //
-  // Checksum: 247ee9ef1df8665b759064856492831661b08985
+  // Checksum: 0d3df25297a4e76b865aee1e908baf355e26d665
 
   /// Deprecation for passing a string directly to meta.call().
   callString('call-string',
@@ -139,6 +139,12 @@ enum Deprecation {
       deprecatedIn: '1.91.0',
       description: 'A rest parameter before a positional or named parameter.'),
 
+  /// Deprecation for configuring private variables in @use, @forward, or load-css().
+  withPrivate('with-private',
+      deprecatedIn: '1.92.0',
+      description:
+          'Configuring private variables in @use, @forward, or load-css().'),
+
   // END AUTOGENERATED CODE
 
   /// Used for deprecations coming from user-authored code.

lib/src/parse/stylesheet.dart

@@ -1652,6 +1652,15 @@ abstract class StylesheetParser extends Parser {
 
       var variableStart = scanner.state;
       var name = variableName();
+      if (name.startsWith('-')) {
+        warnings.add((
+          deprecation: Deprecation.withPrivate,
+          message: 'Configuring private variables is deprecated.\n'
+              'This will be an error in Dart Sass 2.0.0.',
+          span: scanner.spanFrom(variableStart),
+        ));
+      }
+
       whitespace(consumeNewlines: true);
       scanner.expectChar($colon);
       whitespace(consumeNewlines: true);

lib/src/visitor/async_evaluate.dart

@@ -580,11 +580,20 @@ final class _EvaluateVisitor
         if (withMap != null) {
           var values = <String, ConfiguredValue>{};
           var span = callableNode.span;
+          var privateDeprecation = false;
           withMap.forEach((variable, value) {
             var name =
                 variable.assertString("with key").text.replaceAll("_", "-");
             if (values.containsKey(name)) {
               throw "The variable \$$name was configured twice.";
+            } else if (name.startsWith("-") && !privateDeprecation) {
+              privateDeprecation = true;
+              warnForDeprecation(
+                "Configuring private variables (such as \$$name) is "
+                "deprecated.\n"
+                "This will be an error in Dart Sass 2.0.0.",
+                Deprecation.withPrivate,
+              );
             }
 
             values[name] = ConfiguredValue.explicit(value, span, callableNode);

lib/src/visitor/evaluate.dart

@@ -5,7 +5,7 @@
 // DO NOT EDIT. This file was generated from async_evaluate.dart.
 // See tool/grind/synchronize.dart for details.
 //
-// Checksum: 100082e5b65dc126357c027e76f34ae97b3f9e48
+// Checksum: a32ff6b83b3365e8dad72b8b12c2c17937a5f28e
 //
 // ignore_for_file: unused_import
 
@@ -588,11 +588,20 @@ final class _EvaluateVisitor
         if (withMap != null) {
           var values = <String, ConfiguredValue>{};
           var span = callableNode.span;
+          var privateDeprecation = false;
           withMap.forEach((variable, value) {
             var name =
                 variable.assertString("with key").text.replaceAll("_", "-");
             if (values.containsKey(name)) {
               throw "The variable \$$name was configured twice.";
+            } else if (name.startsWith("-") && !privateDeprecation) {
+              privateDeprecation = true;
+              warnForDeprecation(
+                "Configuring private variables (such as \$$name) is "
+                "deprecated.\n"
+                "This will be an error in Dart Sass 2.0.0.",
+                Deprecation.withPrivate,
+              );
             }
 
             values[name] = ConfiguredValue.explicit(value, span, callableNode);

pkg/sass-parser/CHANGELOG.md

@@ -1,4 +1,4 @@
-## 0.4.27-dev
+## 0.4.27
 
 * No user-visible changes.
 

pkg/sass-parser/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sass-parser",
-  "version": "0.4.27-dev",
+  "version": "0.4.27",
   "description": "A PostCSS-compatible wrapper of the official Sass parser",
   "repository": "sass/sass",
   "author": "Google Inc.",

pkg/sass_api/CHANGELOG.md

@@ -1,4 +1,4 @@
-## 15.10.0-dev
+## 15.10.0
 
 * No user-visible changes.
 

pkg/sass_api/pubspec.yaml

@@ -2,7 +2,7 @@ name: sass_api
 # Note: Every time we add a new Sass AST node, we need to bump the *major*
 # version because it's a breaking change for anyone who's implementing the
 # visitor interface(s).
-version: 15.10.0-dev
+version: 15.10.0
 description: Additional APIs for Dart Sass.
 homepage: https://github.com/sass/dart-sass
 

pubspec.yaml

@@ -1,5 +1,5 @@
 name: sass
-version: 1.92.0-dev
+version: 1.92.0
 description: A Sass implementation in Dart.
 homepage: https://github.com/sass/dart-sass