Skip to content

Commit b263a72

Browse files
ntkmenex3
andauthored
Use implementation name dart-sass for VersionResponse (#2156)
Co-authored-by: Natalie Weizenbaum <[email protected]>
1 parent 006baa5 commit b263a72

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
## 1.69.8
2+
3+
### Embedded Sass
4+
5+
* The Dart Sass embedded compiler now reports its name as "dart-sass" rather
6+
than "Dart Sass", to match the JS API's `info` field.
7+
18
## 1.69.7
29

310
### Embedded Sass

lib/src/embedded/isolate_dispatcher.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ class IsolateDispatcher {
137137
..protocolVersion = const String.fromEnvironment("protocol-version")
138138
..compilerVersion = const String.fromEnvironment("compiler-version")
139139
..implementationVersion = const String.fromEnvironment("compiler-version")
140-
..implementationName = "Dart Sass";
140+
..implementationName = "dart-sass";
141141
}
142142

143143
/// Handles an error thrown by the dispatcher or code it dispatches to.

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: sass
2-
version: 1.69.7
2+
version: 1.69.8-dev
33
description: A Sass implementation in Dart.
44
homepage: https://github.com/sass/dart-sass
55

test/embedded/protocol_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ void main() {
9696
Version.parse(response.protocolVersion); // shouldn't throw
9797
Version.parse(response.compilerVersion); // shouldn't throw
9898
Version.parse(response.implementationVersion); // shouldn't throw
99-
expect(response.implementationName, equals("Dart Sass"));
99+
expect(response.implementationName, equals("dart-sass"));
100100
await process.close();
101101
});
102102

0 commit comments

Comments
 (0)