Publish 0.7.0

[mdedetrich]

So we can align on when to publish so we don't miss anything

[mkurz]

Almost done.
I pushed a milestone release, to check if publishing works: https://github.com/sbt/sbt-paradox-material-theme/releases/tag/v0.7.0-M1
Also before final release we want to merge:

• Release notes for 0.7.0 #62

And maybe it makes sense to take a look at

• fix: duplicated slashes #28

which also may be a fix for

• Search not working when not on index page #30

[mdedetrich]

I have been thinking, maybe the 0.7.0/1.0.0 distinction between sbt-paradox/sbt-paradox-theme is not necessary right now and we should just release as 0.7.0 with sbt-paradox/sbt-paradox-theme versions pinned to 0.9.x and only bump sbt-paradox/sbt-paradox-theme to 1.0.0 when we find an actual binary incompatibility between sbt-paradox/sbt-paradox-theme 0.9.x and 0.11.x+.

The sbt-paradox/sbt-paradox-theme API that this project uses is stable from 0.9.x all the way until the latest versions, the actual reason behind the incompatibility are dependencies of sbt-paradox (iirc scala-xml/parboiiled) that are split between supporting JDK 1.8 and JDK 11+ but we never use those dependencies directly.

Thats why doing this trick works.

@mkurz wdyt?

[mkurz]

and only bump sbt-paradox/sbt-paradox-theme

We can not bump these two libraries to 1.x ourselves anyway, because they are hosted under the lightbend org and I do not have access to that repos. I guess you mean this repo here (sbt-paradox-material-theme).

So do I get this right, let's release 0.7.0 with paradox deps pinned to 0.9.2 (actually that is what we wanted to do anyway), branch off a 0.7.x branch from that tag, and then on main upgraded the paradox deps to 0.10.6 and release 0.8.0 (instead of 1.0.0)?

[mkurz]

@mdedetrich Everything done, all PRs merged, also M1 got published without problems.

You want to tag/push 0.7.0?

[mdedetrich]

So do I get this right, let's release 0.7.0 with paradox deps pinned to 0.9.2 (actually that is what we wanted to do anyway), branch off a 0.7.x branch from that tag, and then on main upgraded the paradox deps to 0.10.6 and release 0.8.0 (instead of 1.0.0)?

Well actually I was thinking of just continuing to work on 0.7.x unless we are forced to upgrade paradox deps to 0.10.6 (or later by the time we get to it) because there isn't actually any reason to upgrade the paradox deps and doing so can cause annoyances with JDK 1.8.

[mkurz]

Hmmm... Not sure... I think you see this too much from the perspective of Pekko.
There are other projects that use this library so I am not sure it would be "fair" to hold dependency upgrades back "just" because of Pekko.
What I would do now is: releae 0.7.0 (which we do anyway), branch off 0.7.x so you can still cut 0.7.1 etc. if needed, but on master merge #66 and cut 0.8.0.
To be honest I do not expect great changes to this library currently so it's just about also having a release with all the deps up to date for other projects.

[mdedetrich]

There are other projects that use this library so I am not sure it would be "fair" to hold dependency upgrades back "just" because of Pekko.

Unless I am missing something its not going to impact any project either way, as we speak now you can easily load sbt-paradox-material-theme with sbt-paradox/sbt-paradox-theme 0.10.6 without any issues (I can even write an sbt-scripted test to prove this).

Its the reverse i.e. downgrading the sbt-paradox/sbt-paradox-theme as is here due to JDK 8 that is problematic and thats what Pekko is dealing with.

To be honest I do not expect great changes to this library currently so it's just about also having a release with all the deps up to date for other projects.

There are going to be big changes, see apache/pekko#1097 (comment) . For example the material theme is seriously outdated and an upcoming version (9.x) is meant to be provide much better improved search functionality and its likely to be a big change.

[mdedetrich]

See #67 as a demonstration that this project currently works completely fine with latest version of sbt-paradox/sbt-paradox-theme

[mkurz]

Ok, then we just tag 0.7.0 and we are done I guess?

[mdedetrich]

Ok, then we just tag 0.7.0 and we are done I guess?

Yup!