Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-issue: is changing nameHashes on a trivial change normal? #1427

Open
OndrejSpanel opened this issue Oct 4, 2024 · 1 comment
Open

Pre-issue: is changing nameHashes on a trivial change normal? #1427

OndrejSpanel opened this issue Oct 4, 2024 · 1 comment

Comments

@OndrejSpanel
Copy link

OndrejSpanel commented Oct 4, 2024

Before I delve into creating another reproduced from my project, I would like to check if this is issue or not:

When I make a simple change in my sources, like recently I have changed a content of string like from println(s" list: head=${list.debugString}") to println(s" list: ${list.debugString}"), I see name hashes of many classes in the changed file have changed their nameHashes. Note: I do not observe any visible manifestations on the build itself (no more files are compiled), I observe this just by inspecting sbt.internal.inc.Analysis.

If this is a bug and what kind of visible manifestation could it have?

@Friendseeker
Copy link
Member

Friendseeker commented Oct 4, 2024

This sounds like a bug. Name hash is a hash of public API. Non-API changes should not change name hash.

As for visible manifestation, it probably would cause some unnecessary invalidations...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants