-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is truffle 5.0.0 supported? #309
Comments
I'm running I am keen to know if support for the new solc version is currently in the pipeline? |
For a simple/small contract, I'm able to get coverage working See However for a bigger complexer contract, I still get a lot of errors. |
Couple of issues I've encountered and fixed:
|
Truffle 5.0.0 now allows you to specify the version of solc you want to use to compile your contracts. This works with the default test runner, but not with solidity-coverage (which doesn't use the same test runner in truffle-compile). It does not work with 5.0.0 for contracts which require solc 0.4.x. See https://travis-ci.org/alfabc/braided/builds/471619698#L774 |
Thanks everyone. Sharing the following workaround that has worked for me for
truffle-coverage.js:
Run: IIRC, the "cp" step was necessary because by default, the |
Hi, |
As a temporary fix, copy https://raw.githubusercontent.com/maxsam4/solidity-parser/solidity-0.5/build/parser.js to As I am doing in the truffle-5 branch for polymath-core, you may configure your CI to replace this file automatically using
Waiting for @cgewecke to be active once again and merge sc-forks/solidity-parser#18 and 17. |
But is your PR supporting truffle v5, solidity 0.5.x and using web3.js-1.0.0-beta.x ? |
You can try this but its not official, I use the code of @maxsam4 and @angus-hamill, add my fork in your package.json Works with calldata and address payable |
Awesome, but what I see here is a bunch of forks. |
I believe this pr is #311. Hasn't been touched in 2 weeks though. |
This PR actually fixes the problem, I've been using it for a while. The only thing failing is the tests because they are using old stuff, for example, very old examples of code from open zeppelin. I have a lot more work to do so instead of just being here spending time for maybe nothing I decided to get in touch with truffle team. They know that this is not being maintained and they want to add coverage to their tests, but they might not use this framework. This is the reason I gave up about it. It's too much work for nothing. Sorry to disappoint you. One thing I'm sure is that what is said on the PR #311 is working. Might need some changes, but so far, for me is working well. |
For those interested in this issue, I would be interested in any peculiar results or behaviour you found when trying to use the |
|
The package.json currently specifies Truffle 4
https://github.com/sc-forks/solidity-coverage/blob/master/package.json#L49
Does
solidity-coverage
work with projects created usingtruffle 5.0.0
?The text was updated successfully, but these errors were encountered: