Skip to content

Conversation

@Dima-X
Copy link
Contributor

@Dima-X Dima-X commented Apr 4, 2025

Description

This PR adds sample application for ScalarDB Cluster .NET Client SDK that uses LINQ.
This is a LINQ version of #77

Related issues and/or PRs

https://github.com/scalar-labs/docs-internal-scalardb/pull/1062

Changes made

  • sample added to scalardb-dotnet-samples/scalardb-cluster-linq-sample
  • Visual Studio specific exceptions were added to .gitignore

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

@Dima-X Dima-X self-assigned this Apr 4, 2025
@Dima-X Dima-X requested review from a team, Torch3333, brfrn169, feeblefakie, komamitsu and kota2and3kan and removed request for a team April 4, 2025 03:08
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@komamitsu
Copy link
Contributor

@feeblefakie @brfrn169 @Torch3333 I added a small fix to throw the last exception when the retry is over 2faa2e9. PTAL just in case.

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!


FYI: I was able to run this sample application in my local environment as follows:

$ dotnet run PlaceOrder 1 3:1,4:1
{
  "order_id": "ab391787-302d-446d-8f85-429432df4dd9"
}

@brfrn169 brfrn169 merged commit 93794ab into main Apr 10, 2025
32 checks passed
@brfrn169 brfrn169 deleted the add-dotnet-scalardb-cluster-linq-sample branch April 10, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants