detach pn in delete resource

Author: jremy42

internal/services/mongodb/instance.go

@@ -550,6 +550,26 @@ func ResourceInstanceDelete(ctx context.Context, d *schema.ResourceData, m inter
 		return diag.FromErr(err)
 	}
 
+	instance, err := waitForInstance(ctx, mongodbAPI, region, ID, d.Timeout(schema.TimeoutDelete))
+	if err != nil {
+		return diag.FromErr(err)
+	}
+
+	for _, endpoint := range instance.Endpoints {
+		if endpoint.PrivateNetwork != nil {
+			err := mongodbAPI.DeleteEndpoint(
+				&mongodb.DeleteEndpointRequest{
+					EndpointID: endpoint.ID,
+					Region:     region,
+				},
+				scw.WithContext(ctx),
+			)
+			if err != nil {
+				return diag.FromErr(err)
+			}
+		}
+	}
+
 	_, err = waitForInstance(ctx, mongodbAPI, region, ID, d.Timeout(schema.TimeoutDelete))
 	if err != nil {
 		return diag.FromErr(err)
@@ -569,6 +589,5 @@ func ResourceInstanceDelete(ctx context.Context, d *schema.ResourceData, m inter
 	}
 
 	d.SetId("")
-
 	return nil
 }

internal/services/mongodb/instance_test.go

@@ -234,7 +234,6 @@ func TestAccMongoDBInstance_WithPrivateNetwork(t *testing.T) {
 						private_network {
 							pn_id = "${scaleway_vpc_private_network.pn01.id}"
 						}
-  						depends_on = [scaleway_vpc_private_network.pn01]
 					}
 				`,
 				Check: resource.ComposeTestCheckFunc(
@@ -300,8 +299,6 @@ func TestAccMongoDBInstance_UpdatePrivateNetwork(t *testing.T) {
 						private_network {
 							pn_id = "${scaleway_vpc_private_network.pn01.id}"
 						}
-  						depends_on = [scaleway_vpc_private_network.pn01, scaleway_vpc_private_network.pn02]
-
 					}
 				`,
 				Check: resource.ComposeTestCheckFunc(
@@ -334,7 +331,6 @@ func TestAccMongoDBInstance_UpdatePrivateNetwork(t *testing.T) {
 						private_network {
 							pn_id = "${scaleway_vpc_private_network.pn02.id}"
 						}
-  						depends_on = [scaleway_vpc_private_network.pn01, scaleway_vpc_private_network.pn02]
 					}
 				`,
 				Check: resource.ComposeTestCheckFunc(
@@ -364,7 +360,6 @@ func TestAccMongoDBInstance_UpdatePrivateNetwork(t *testing.T) {
 						node_number = 1
 						user_name = "my_initial_user"
 						password = "thiZ_is_v&ry_s3cret"
-  						depends_on = [scaleway_vpc_private_network.pn01, scaleway_vpc_private_network.pn02]
 					}
 				`,
 				Check: resource.ComposeTestCheckFunc(