Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Action status with failed builds #57

Open
bsipocz opened this issue Sep 7, 2024 · 2 comments
Open

BUG: Action status with failed builds #57

bsipocz opened this issue Sep 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@bsipocz
Copy link
Member

bsipocz commented Sep 7, 2024

I wonder what the actions' status actually means, as e.g. here the build HTML fails due to an exception in one of the cells, yet the HTMLs are generated without issues, and those HTMLs are successfully redirected. Yet the status of the redirect is failing, too.

networkx/nx-guides#131

Screenshot 2024-09-07 at 09 58 23
@bsipocz bsipocz added the bug Something isn't working label Sep 7, 2024
@bsipocz bsipocz changed the title Action status with failed builds BUG: Action status with failed builds Sep 7, 2024
@larsoner
Copy link
Collaborator

So far the status just mirrors whatever the status of the original build was. But we could change it to be "green if the linked artifact is present, red otherwise".

@bsipocz
Copy link
Member Author

bsipocz commented Sep 11, 2024

But we could change it to be "green if the linked artifact is present, red otherwise".

I would find that useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants