tests: reproducible on Python < 3.9 (just different) (#66)

- tests: tarfile on older Pythons was different.
- tests: adding failing test for wheel

Signed-off-by: Henry Schreiner <[email protected]>

Author: henryiii

tests/test_pyproject_pep517.py

@@ -32,8 +32,8 @@
 """
 
 mark_hashes_different = pytest.mark.xfail(
-    sys.version_info < (3, 9) or sys.platform.startswith("win32"),
-    reason="hashes differ on Windows and Python < 3.9",
+    sys.platform.startswith("win32"),
+    reason="hashes differ on Windows",
 )
 
 
@@ -75,7 +75,14 @@ def test_pep517_sdist_hash(tmp_path, monkeypatch):
     out = build_sdist(str(dist))
     sdist = dist / out
     hash = hashlib.sha256(sdist.read_bytes()).hexdigest()
-    assert hash == "03455cc6996c1d0d4977bedb611180cf561ade9d70d7b5d1216a40405adf7b47"
+    if sys.version_info < (3, 9):
+        assert (
+            hash == "09b0593a80d0b0c086fddb99378e6dc75ba50e041076cd4a9a7afe4053407362"
+        )
+    else:
+        assert (
+            hash == "03455cc6996c1d0d4977bedb611180cf561ade9d70d7b5d1216a40405adf7b47"
+        )
 
 
 def test_pep517_sdist_time_hash(tmp_path, monkeypatch):
@@ -136,7 +143,14 @@ def test_pep517_sdist_time_hash_set_epoch(tmp_path, monkeypatch):
     out = build_sdist(str(dist), {"scikit-build-core.sdist.reproducible": "false"})
     sdist = dist / out
     hash = hashlib.sha256(sdist.read_bytes()).hexdigest()
-    assert hash == "a39a0eecb02f7b583ab3008c0c64c55eaef9d0bb5e712b6cb8d469598771ddfb"
+    if sys.version_info < (3, 9):
+        assert (
+            hash == "7656ce7df4c1d6bbd098f046f75bb610104260542de5eeaf40993bb2976bf34e"
+        )
+    else:
+        assert (
+            hash == "a39a0eecb02f7b583ab3008c0c64c55eaef9d0bb5e712b6cb8d469598771ddfb"
+        )
 
 
 @pytest.mark.compile
@@ -189,3 +203,31 @@ def test_pep517_wheel(tmp_path, monkeypatch, virtualenv):
         capture=True,
     )
     assert add.strip() == "3"
+
+
+@pytest.mark.skip(reason="Doesn't work yet")
+@pytest.mark.compile
+@pytest.mark.configure
+def test_pep517_wheel_time_hash(tmp_path, monkeypatch):
+    dist = tmp_path / "dist"
+    dist.mkdir()
+    monkeypatch.chdir(HELLO_PEP518)
+    monkeypatch.setenv("SOURCE_DATE_EPOCH", "12345")
+    if Path("dist").is_dir():
+        shutil.rmtree("dist")
+    out = build_wheel(str(dist))
+    wheel = dist / out
+    hash1 = hashlib.sha256(wheel.read_bytes()).hexdigest()
+
+    time.sleep(2)
+    Path("src/main.cpp").touch()
+
+    if Path("dist").is_dir():
+        shutil.rmtree("dist")
+
+    out = build_wheel(str(dist))
+    wheel = dist / out
+
+    hash2 = hashlib.sha256(wheel.read_bytes()).hexdigest()
+
+    assert hash1 == hash2

tests/test_pyproject_pep518.py

@@ -11,7 +11,6 @@
 
 DIR = Path(__file__).parent.resolve()
 HELLO_PEP518 = DIR / "packages/simple_pyproject_ext"
-KNOWN_SDIST_HASH = "03455cc6996c1d0d4977bedb611180cf561ade9d70d7b5d1216a40405adf7b47"
 
 
 @pytest.mark.integration
@@ -35,8 +34,18 @@ def test_pep518_sdist(pep518, virtualenv):
     (sdist,) = dist.iterdir()
     assert "cmake-example-0.0.1.tar.gz" == sdist.name
 
-    if sys.version_info >= (3, 9) and not sys.platform.startswith("win32"):
-        assert hashlib.sha256(sdist.read_bytes()).hexdigest() == KNOWN_SDIST_HASH
+    if not sys.platform.startswith("win32"):
+        hash = hashlib.sha256(sdist.read_bytes()).hexdigest()
+        if sys.version_info < (3, 9):
+            assert (
+                hash
+                == "09b0593a80d0b0c086fddb99378e6dc75ba50e041076cd4a9a7afe4053407362"
+            )
+        else:
+            assert (
+                hash
+                == "03455cc6996c1d0d4977bedb611180cf561ade9d70d7b5d1216a40405adf7b47"
+            )
 
     with tarfile.open(sdist) as f:
         file_names = set(f.getnames())