We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Lasso
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We have a considerable overhead when fitting Lasso Estimator as shown in the screenshot below
To reproduce go to benchopt Lasso benchmark repo
After investigating, this overhead is because of the computation of the global_lipschitz
global_lipschitz
skglm/skglm/datafits/single_task.py
Lines 52 to 54 in cca6d48
that we introduced after adding the FISTA solver #91.
The global_lipschitz is only relevant for the FISTA solver. Hence, it should be computed only in this case.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Description
We have a considerable overhead when fitting Lasso Estimator as shown in the screenshot below
To reproduce go to benchopt Lasso benchmark repo
Investigation
After investigating, this overhead is because of the computation of the
global_lipschitz
skglm/skglm/datafits/single_task.py
Lines 52 to 54 in cca6d48
that we introduced after adding the FISTA solver #91.
Potential fix
The
global_lipschitz
is only relevant for the FISTA solver. Hence, it should be computed only in this case.The text was updated successfully, but these errors were encountered: