Skip to content

Considerable overhead when fitting with Lasso #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Badr-MOUFAD opened this issue Nov 29, 2022 · 0 comments · Fixed by #129
Closed

Considerable overhead when fitting with Lasso #128

Badr-MOUFAD opened this issue Nov 29, 2022 · 0 comments · Fixed by #129

Comments

@Badr-MOUFAD
Copy link
Collaborator

Badr-MOUFAD commented Nov 29, 2022

Description

We have a considerable overhead when fitting Lasso Estimator as shown in the screenshot below

To reproduce go to benchopt Lasso benchmark repo

Investigation

After investigating, this overhead is because of the computation of the global_lipschitz

n_features = X.shape[1]
self.global_lipschitz = norm(X, ord=2) ** 2 / len(y)
self.lipschitz = np.zeros(n_features, dtype=X.dtype)

that we introduced after adding the FISTA solver #91.

Potential fix

The global_lipschitz is only relevant for the FISTA solver. Hence, it should be computed only in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant