Merge pull request #28 from open-source-contributions/test_improvement

Andrew Scott · web-flow · commit a6c1c98a3985 · 2020-03-18T07:37:17.000+11:00
Test improvement
diff --git a/.gitignore b/.gitignore
@@ -3,3 +3,4 @@ composer.phar
 phpunit.xml
 vendor/
 build/
+.phpunit.result.cache
diff --git a/.travis.yml b/.travis.yml
@@ -10,6 +10,6 @@ jobs:
   fast_finish: true
 
 before_script:
-  - composer install --dev --prefer-source
+  - composer install --prefer-source
 
-script: ./vendor/bin/phpunit --coverage-text
+script: ./vendor/bin/phpunit --coverage-text
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -2,7 +2,7 @@
 <phpunit bootstrap="vendor/autoload.php"
 		 colors="true">
     <testsuites>
-        <testsuite>
+        <testsuite name="php-dom-wrapper testsuite">
             <directory>tests</directory>
         </testsuite>
     </testsuites>
@@ -20,4 +20,4 @@
 			<directory suffix=".php">src</directory>
         </whitelist>
     </filter>
-</phpunit>
+</phpunit>
diff --git a/tests/Node/DocumentTest.php b/tests/Node/DocumentTest.php
@@ -16,7 +16,7 @@ public function testDocumentSetHtmlEncoding() {
     public function testDocumentParent() {
         $doc = $this->document('<html></html>');
 
-        $this->assertSame(null, $doc->parent());
+        $this->assertNull($doc->parent());
     }
 
     public function testDocumentParents() {
@@ -35,6 +35,6 @@ public function testDocumentClone() {
         $doc = $this->document('<html></html>');
         $clone = $doc->_clone();
 
-        $this->assertSame(null, $clone);
+        $this->assertNull($clone);
     }
-}
+}
diff --git a/tests/Traversal/EqTest.php b/tests/Traversal/EqTest.php
@@ -26,7 +26,7 @@ public function testEq() {
         $this->assertInstanceOf('\DOMNode', $nodes->eq(3));
         $this->assertSame('div', $nodes->eq(3)->nodeName);
 
-        $this->assertSame(null, $nodes->eq(4));
+        $this->assertNull($nodes->eq(4));
 
         $this->assertInstanceOf('\DOMNode', $nodes->eq(-1));
         $this->assertSame('div', $nodes->eq(-1)->nodeName);
@@ -41,6 +41,6 @@ public function testEq() {
         $this->assertSame('div', $nodes->eq(-4)->nodeName);
         $this->assertSame('example', $nodes->eq(-4)->attr('class'));
 
-        $this->assertSame(null, $nodes->eq(-5));
+        $this->assertNull($nodes->eq(-5));
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ public function testDocumentSetHtmlEncoding() {`
`16`	`16`	`public function testDocumentParent() {`
`17`	`17`	`$doc = $this->document('<html></html>');`
`18`	`18`
`19`		`- $this->assertSame(null, $doc->parent());`
	`19`	`+ $this->assertNull($doc->parent());`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`public function testDocumentParents() {`
`@@ -35,6 +35,6 @@ public function testDocumentClone() {`
`35`	`35`	`$doc = $this->document('<html></html>');`
`36`	`36`	`$clone = $doc->_clone();`
`37`	`37`
`38`		`- $this->assertSame(null, $clone);`
	`38`	`+ $this->assertNull($clone);`
`39`	`39`	`}`
`40`		`-}`
	`40`	`+}`