Skip to content

Commit 45634b2

Browse files
authored
Add value validations for structured event (#10)
1 parent 0a33a69 commit 45634b2

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lib/snowplow_tracker/events/structured.ex

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ defmodule SnowplowTracker.Events.Structured do
5252
action: Map.get(data, :action),
5353
label: Map.get(data, :label),
5454
property: Map.get(data, :property),
55-
value: Map.get(data, :value, 0.0),
55+
value: Map.get(data, :value, nil),
5656
timestamp: Map.get(data, :timestamp, EventsHelper.generate_timestamp()),
5757
event_id: Map.get(data, :event_id, EventsHelper.generate_uuid()),
5858
true_timestamp: Map.get(data, :true_timestamp, EventsHelper.generate_timestamp()),
@@ -81,12 +81,12 @@ defmodule SnowplowTracker.Events.Structured do
8181
raise Errors.InvalidParam, "action cannot be blank"
8282
end
8383

84-
def validate(%Structured{value: ""}) do
85-
raise Errors.InvalidParam, "value cannot be blank"
84+
def validate(%Structured{value: value}) when is_binary(value) do
85+
raise Errors.InvalidParam, "value cannot be a string"
8686
end
8787

88-
def validate(%Structured{value: nil}) do
89-
raise Errors.InvalidParam, "value cannot be blank"
88+
def validate(%Structured{value: value}) when is_integer(value) do
89+
raise Errors.InvalidParam, "value cannot be a integer"
9090
end
9191

9292
def validate(%Structured{} = event), do: event

0 commit comments

Comments
 (0)