Merge pull request #5 from scripbox/task/accept-httpoison-options

Accept HTTPoison options from configuration

Author: goodhamgupta

config/config.exs

@@ -10,11 +10,11 @@ use Mix.Config
 
 # You can configure your application as:
 #
-#     config :snowplow_elixir_tracker, key: :value
+#     config :snowplow_tracker, key: :value
 #
 # and access this configuration in your application as:
 #
-#     Application.get_env(:snowplow_elixir_tracker, :key)
+#     Application.get_env(:snowplow_tracker, :key)
 #
 # You can also configure a 3rd-party app:
 #
@@ -28,3 +28,9 @@ use Mix.Config
 # here (which is why it is important to import them last).
 #
 #     import_config "#{Mix.env}.exs"
+
+config :snowplow_tracker,
+  default_options: [
+    timeout: 5000,
+    recv_timeout: 2000
+  ]

lib/snowplow_tracker/emitter.ex

@@ -40,12 +40,16 @@ defmodule SnowplowTracker.Emitter do
         emitter.request_type
       )
 
-    with {:ok, response} <- Request.get(url, [recv_timeout: 50000]),
+    with {:ok, response} <- Request.get(url, [], default_options()),
          {:ok, body} <- Response.parse(response) do
       {:ok, body}
     else
       {:error, error} ->
         raise Errors.ApiError, Kernel.inspect(error)
     end
   end
+
+  defp default_options do
+    Application.get_env(:snowplow_tracker, :default_options) || []
+  end
 end

mix.exs

@@ -4,7 +4,7 @@ defmodule SnowplowTracker.MixProject do
   def project do
     [
       app: :snowplow_tracker,
-      version: "0.1.0",
+      version: "0.1.1",
       elixir: "~> 1.6",
       start_permanent: Mix.env() == :prod,
       test_coverage: [tool: ExCoveralls],

test/snowplow_tracker/emitter_test.exs

@@ -7,7 +7,7 @@ defmodule SnowplowTracker.EmitterTest do
 
   defmacro with_request_mock(block) do
     quote do
-      with_mock Request, get: fn (url, opts) -> RequestMock.get(url, opts) end do
+      with_mock Request, get: fn url, headers, opts -> RequestMock.get(url, headers, opts) end do
         unquote(block)
       end
     end

test/snowplow_tracker_test.exs

@@ -13,7 +13,7 @@ defmodule SnowplowTrackerTest do
 
   defmacro with_request_mock(block) do
     quote do
-      with_mock Request, get: fn (url, opts) -> RequestMock.get(url, opts) end do
+      with_mock Request, get: fn url, headers, opts -> RequestMock.get(url, headers, opts) end do
         unquote(block)
       end
     end

test/support/request_mock.ex

@@ -1,7 +1,7 @@
 defmodule SnowplowTracker.RequestMock do
   require HTTPoison
 
-  def get(_, _) do
+  def get(_url, _headers, _options) do
     send(self(), "request sent")
     {:ok, %HTTPoison.Response{status_code: 200, body: "response"}}
   end