Skip to content

Commit 02824da

Browse files
authored
chore: remove default bound for txs (paradigmxyz#12834)
1 parent 53839a9 commit 02824da

File tree

4 files changed

+2
-20
lines changed

4 files changed

+2
-20
lines changed

crates/primitives-traits/src/node.rs

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -42,16 +42,7 @@ pub trait NodePrimitives:
4242
+ MaybeSerde
4343
+ 'static;
4444
/// Signed version of the transaction type.
45-
type SignedTx: Send
46-
+ Sync
47-
+ Unpin
48-
+ Clone
49-
+ Default
50-
+ fmt::Debug
51-
+ PartialEq
52-
+ Eq
53-
+ MaybeSerde
54-
+ 'static;
45+
type SignedTx: Send + Sync + Unpin + Clone + fmt::Debug + PartialEq + Eq + MaybeSerde + 'static;
5546
/// Transaction envelope type ID.
5647
type TxType: Send + Sync + Unpin + Clone + Default + fmt::Debug + PartialEq + Eq + 'static;
5748
/// A receipt.

crates/primitives-traits/src/transaction/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ pub trait Transaction:
1818
+ Sync
1919
+ Unpin
2020
+ Clone
21-
+ Default
2221
+ fmt::Debug
2322
+ Eq
2423
+ PartialEq
@@ -35,7 +34,6 @@ impl<T> Transaction for T where
3534
+ Sync
3635
+ Unpin
3736
+ Clone
38-
+ Default
3937
+ fmt::Debug
4038
+ Eq
4139
+ PartialEq

crates/primitives-traits/src/transaction/signed.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ pub trait SignedTransaction:
1818
+ Sync
1919
+ Unpin
2020
+ Clone
21-
+ Default
2221
+ fmt::Debug
2322
+ PartialEq
2423
+ Eq

crates/primitives/src/transaction/pooled.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ use crate::{
1111
use alloy_consensus::{
1212
constants::EIP4844_TX_TYPE_ID,
1313
transaction::{TxEip1559, TxEip2930, TxEip4844, TxLegacy},
14-
SignableTransaction, Signed, TxEip4844WithSidecar,
14+
Signed, TxEip4844WithSidecar,
1515
};
1616
use alloy_eips::{
1717
eip2718::{Decodable2718, Eip2718Result, Encodable2718},
@@ -226,12 +226,6 @@ impl PooledTransactionsElement {
226226
}
227227
}
228228

229-
impl Default for PooledTransactionsElement {
230-
fn default() -> Self {
231-
Self::Legacy(TxLegacy::default().into_signed(Signature::test_signature()))
232-
}
233-
}
234-
235229
impl Hash for PooledTransactionsElement {
236230
fn hash<H: Hasher>(&self, state: &mut H) {
237231
self.trie_hash().hash(state);

0 commit comments

Comments
 (0)