Feat: stable phase1/phase2 (#84)

* phase1 tested

* seems ok

* lint

* cleanup

* fix(TOB-SCREUC-1): at least 1 pi | pis and pi_hashes are equal in length

* chore: rename chunk infos

* fix(TOB-SCREUC-2): insufficient validation of chunk info between witness and blob

* fix(TOB-SCREUC-5): lax parsing of batch payload

* fix: code quality recommendations

* chore: update commitments

* fix: update v3 payload parsing

* chore: update commitments

* [Fix] for phase1 rc9 (#87)

* fix pi hash in bundle

* add santiy check for bundle task

* fix typo and expression

* add local task test, output local task in e2e

* + add bundle local task sample, update batch local task sample
+ sanity check for final e2e bundle pi

* rc9

* rc9

* phase2

* done

* feat: extend prover config

* fix(integration): compile OK

* chore: bump rc10 and update commitments

* upgrade openvm (#97)

* upgrade openvm

* chore: update snark-verifier-sdk

* chore: update tiny-keccak

* chore: upgrade openvm (alloy-core, revm, reth, sbv)

* chore: update sbv

* chore(build-guest): build both since openvm upgraded

* chore: update commitments

---------

Co-authored-by: Rohit Narurkar <[email protected]>

* Update the comment for kzg g2 setup (#88)

* chore: update commitments

* Phase-2 audit fixes (#98)

* fix(TOB-SCREUC2-3): use github output instead of github env

* fix(TOB-SCREUC2-4): pin 3rd party actions

* fix(TOB-SCREUC2-5): do not persist git credentials

* feat: runtime multi version (#81)

* circuit::types can support multi versions

* phase feature free for batch circuit

* fix issue after merging

* make chunk circuit feature free

* prune unnecessary commitment file, and revert verify_commitments update

* fix: soundnes in bundle circuit and typo

* bundle circuit feature free

* refactoring:
Rename codec_version => fork_name
unitfy the occurance of fork_name field among task and witness (not info)

* resume multiple version of bundle circuit

* update build-guest

* update make file

* fix build-guest

* update lock

* fix issue in build guest input

* enable co-exist of mutiple bundle app

* fix typo

* fix "most legacy" issue

* update release scripts

* [FEAT] better test structure (#82)

* better structure for testdata (WIP)

* fix chunk test and prune batch test (WIP)

* update make file and test samples

* test new batch test scheme

* add batch invariant test

* update makefile for required chunk proof

* prune unnecessary container cleanning

* fixings after rebase

* fix according to review: use more straight fashion for chunk task generations

* FIX: the correct order in batchheader enum

* better version setting for test task

* add readme files

* rename v3 to v6

* rename "legacy" to "euclidv1" according to review

* renaming in scripts

* task must use explicitily specified `fork_name`

* update the sanity check of bundle hash in e2e of phase v1 since the "version" field in batchheader changed (7->6)

---------

Co-authored-by: noelwei <[email protected]>
Co-authored-by: Ho <[email protected]>

* chore: update commitments

* upgrade openvm and revm; fix pairing edge cases

* add commitments

* fmt

* pruge unused bls12_381 openvm extension in bundle circuit

* fix(TOB-SCREUC2-3) follow-up: extract variable and use

* feat: rv32 chunk fallback (#100)

* feat: batch support rv32 chunk

* add ChunkRv32Prover and e2e tests, testing

* add commitment verify for rv32 fallback in verifier

* testing e2e

* add commitments

* toolchain & lint

* docker

* tag 0.2.0

* update commits

---------

Co-authored-by: noelwei <[email protected]>

* clean

* chore: cleanup

* chore: update commitments

* feat(build-guest): write digests

* fix(build-guest): add digests

* fix: batch task v7 contains unpadded blob bytes, envelope v7 expects padded

* [Feat] sanity check for pi while generating proof (#102)

* sanity check for pi in proof gen

* update according to review

* fix another issue

* add missed assert

* resume the comment

* chore: update commitments

* fix: update release script to push digests from correct source path

* fix(tests): prev msg queue hash population for euclidv1

* fix: sanity check on wrapped proof

* fix: tests

* chore: update commitments

---------

Co-authored-by: Rohit Narurkar <[email protected]>
Co-authored-by: Ho <[email protected]>
Co-authored-by: xkx <[email protected]>
Co-authored-by: Ho <[email protected]>

Author: 4 people

.github/workflows/build-guest.yml

@@ -36,6 +36,8 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
+        with:
+          persist-credentials: false
 
       - name: chunk commitments (prover)
         id: commitments-chunk-prover
@@ -110,31 +112,31 @@ jobs:
           } >> $GITHUB_OUTPUT
 
       - name: Sanity check for chunk-commitments (prover vs verifier)
-        uses: nick-fields/assert-action@v1
+        uses: nick-fields/assert-action@aa0067e01f0f6545c31755d6ca128c5a3a14f6bf # v2.0.0
         with:
           expected: ${{ steps.commitments-chunk-prover.outputs.commitments }}
           actual: ${{ steps.commitments-chunk-verifier.outputs.commitments }}
 
       - name: Sanity check for chunk-commitments (prover vs circuits)
-        uses: nick-fields/assert-action@v1
+        uses: nick-fields/assert-action@aa0067e01f0f6545c31755d6ca128c5a3a14f6bf # v2.0.0
         with:
           expected: ${{ steps.commitments-chunk-prover.outputs.commitments }}
           actual: ${{ steps.commitments-chunk-circuits.outputs.commitments }}
 
       - name: Sanity check for batch-commitments (prover vs verifier)
-        uses: nick-fields/assert-action@v1
+        uses: nick-fields/assert-action@aa0067e01f0f6545c31755d6ca128c5a3a14f6bf # v2.0.0
         with:
           expected: ${{ steps.commitments-batch-prover.outputs.commitments }}
           actual: ${{ steps.commitments-batch-verifier.outputs.commitments }}
 
       - name: Sanity check for batch-commitments (prover vs circuits)
-        uses: nick-fields/assert-action@v1
+        uses: nick-fields/assert-action@aa0067e01f0f6545c31755d6ca128c5a3a14f6bf #v2.0.0
         with:
           expected: ${{ steps.commitments-batch-prover.outputs.commitments }}
           actual: ${{ steps.commitments-batch-circuits.outputs.commitments }}
 
       - name: Sanity check for bundle-commitments (prover vs verifier)
-        uses: nick-fields/assert-action@v1
+        uses: nick-fields/assert-action@aa0067e01f0f6545c31755d6ca128c5a3a14f6bf #v2.0.0
         with:
           expected: ${{ steps.commitments-bundle-prover.outputs.commitments }}
           actual: ${{ steps.commitments-bundle-verifier.outputs.commitments }}
@@ -146,7 +148,7 @@ jobs:
           git diff --quiet && echo "no diff" || (echo "diff"; exit 1)
 
       - name: Upload artifact (chunk app.vmexe)
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 #v4.6.2
         with:
           name: chunk-app-vmexe
           path: ./crates/circuits/chunk-circuit/openvm/app.vmexe

.github/workflows/lint.yml

@@ -19,7 +19,7 @@ jobs:
       should_skip: ${{ steps.skip_check.outputs.should_skip }}
     steps:
       - id: skip_check
-        uses: fkirc/skip-duplicate-actions@v5
+        uses: fkirc/skip-duplicate-actions@f75f66ce1886f00957d99748a42c724f4330bdcf #v5.3.1
         with:
           cancel_others: 'true'
           concurrent_skipping: same_content_newer
@@ -35,10 +35,14 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: "nightly-2024-12-06"
+          persist-credentials: false
+
+      - uses: dtolnay/rust-toolchain@56f84321dbccf38fb67ce29ab63e4754056677e0
+        with:
+          toolchain: "nightly-2025-02-14"
           components: rustfmt
+
       - name: Cargo fmt
         run: cargo fmt --all -- --check
 
@@ -52,9 +56,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: "nightly-2024-12-06"
+          persist-credentials: false
+
+      - uses: dtolnay/rust-toolchain@56f84321dbccf38fb67ce29ab63e4754056677e0
+        with:
+          toolchain: "nightly-2025-02-14"
           components: clippy
+
       - name: Clippy
         run: make clippy

.github/workflows/profile-guest.yml

@@ -13,6 +13,8 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
+        with:
+          persist-credentials: false
 
       - name: Download artifact (chunk app.vmexe)
         uses: actions/download-artifact@v4
@@ -21,23 +23,25 @@ jobs:
           path: ./crates/circuits/chunk-circuit/openvm/
 
       - name: Setup rust
-        uses: dtolnay/rust-toolchain@master
+        uses: dtolnay/rust-toolchain@56f84321dbccf38fb67ce29ab63e4754056677e0
         with:
-          toolchain: nightly-2024-12-06
+          toolchain: nightly-2025-02-14
 
       - name: Guest profiling to capture total_cycles
         id: guest-profiling
         run: |
           # Run the tests and capture the output
           output=$(make profile-chunk | grep "scroll-zkvm-integration(chunk-circuit): total cycles = ")
-          echo "total_cycles=$output" >> $GITHUB_ENV
+          echo "total_cycles=$output" >> $GITHUB_OUTPUT
 
       - name: Update PR Description
         uses: actions/github-script@v6
+        env:
+          TOTAL_CYCLES: ${{ steps.guest-profiling.outputs.total_cycles }}
         with:
           script: |
             const prNumber = context.payload.pull_request.number;
-            const totalCycles = process.env.total_cycles;
+            const totalCycles = '${TOTAL_CYCLES}';
             const currentBody = context.payload.pull_request.body;
 
             // Update the PR description with the total cycles

.gitignore

@@ -8,10 +8,6 @@
 
 root_verifier.asm
 
-crates/verifier/testdata/euclidv1/root-verifier-vm-config
-crates/verifier/testdata/euclidv1/root-verifier-committed-exe
-crates/verifier/testdata/euclidv1/verifier.bin
-
-crates/verifier/testdata/euclidv2/root-verifier-vm-config
-crates/verifier/testdata/euclidv2/root-verifier-committed-exe
-crates/verifier/testdata/euclidv2/verifier.bin
+root-verifier-vm-config
+root-verifier-committed-exe
+verifier.bin