Make it compression=None a valid case #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Test case? |
dkropachev
force-pushed
the
dk/enable-none-compression
branch
from
5239b6b to
787e07e
Compare
Collaborator
Author
Added |
dkropachev
force-pushed
the
dk/enable-none-compression
branch
from
787e07e to
0ff7104
Compare
avikivity
approved these changes
Dec 7, 2025
Lorak-mmk
approved these changes
Dec 7, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression where compression=None was incorrectly rejected. The fix treats compression=None the same as compression=False by converting it using bool(compression), which evaluates to False when compression is None.
Key Changes:
- Updated type annotations to accept
Noneas a valid compression value - Added logic to convert
NonetoFalseusingbool(compression) - Added comprehensive test coverage for the
compression=Nonescenario
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cassandra/cluster.py | Updated type annotations for the compression parameter to include None, and added handling logic to convert None to False |
| tests/unit/test_cluster.py | Added comprehensive test cases for compression behavior, including a scenario testing compression=None in test_connection_factory_passes_compression_kwarg |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This regression was cased by 78f5542 And missed during review. compression=None is the same as compression=False, but it is valid now.
dkropachev
force-pushed
the
dk/enable-none-compression
branch
from
0ff7104 to
c6847d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regression was cased by 78f5542 And missed during review.
compression=None is the same as compression=False, but it is valid now.
Fixes: #612
Pre-review checklist
I added relevant tests for new features and bug fixes.PR description sums up the changes and reasons why they should be introduced.I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.I added appropriateFixes:annotations to PR description.