refactor: implement dependency injection for HealthRepository

Co-Authored-By: Claude <[email protected]>

Author: marc0der

prompts/03-health_check_endpoint-todo.md

@@ -6,7 +6,7 @@ Consider the following rules during execution of the tasks:
 
 ### Task 1: Implement Dependency Injection for HealthRepository
 
-- [ ] Refactor dependency injection to properly inject HealthRepository interface
+- [X] Refactor dependency injection to properly inject HealthRepository interface
 
 **Prompt**: Refactor the dependency injection pattern for HealthRepository to follow the same pattern as VersionsRepository. Address the TODO comments in `src/main/kotlin/io/sdkman/Application.kt` at line 20, `src/main/kotlin/io/sdkman/plugins/Routing.kt` at line 32, and line 34. The changes should: (1) Instantiate the HealthRepository in the Application.kt file and pass it to configureRouting function, (2) Update the configureRouting function signature to accept HealthRepository by interface rather than instantiating HealthRepositoryImpl directly, and (3) Remove the direct instantiation of HealthRepositoryImpl from the routing configuration. Follow the existing dependency injection pattern used for VersionsRepository.
 
@@ -35,4 +35,4 @@ The following workflow applies when executing this TODO list:
 - **Ask me to review the task once you have completed and then WAIT FOR ME**
 - Mark the TODO item as complete with [X]
 - Commit the change to Git when I've approved and/or amended the code
-- Move on to the next task
+- Move on to the next task

src/main/kotlin/io/sdkman/Application.kt

@@ -4,6 +4,7 @@ import io.ktor.server.application.*
 import io.sdkman.config.configureAppConfig
 import io.sdkman.plugins.*
 import io.sdkman.repos.VersionsRepository
+import io.sdkman.repos.HealthRepositoryImpl
 
 fun main(args: Array<String>) = io.ktor.server.netty.EngineMain.main(args)
 
@@ -17,6 +18,5 @@ fun Application.module() {
     configureSerialization()
     configureBasicAuthentication(appConfig.apiAuthenticationConfig)
 
-    //TODO: Instantiate the HealthRepository here and inject
-    configureRouting(VersionsRepository())
+    configureRouting(VersionsRepository(), HealthRepositoryImpl())
 }

src/main/kotlin/io/sdkman/plugins/Routing.kt

@@ -12,7 +12,7 @@ import io.sdkman.domain.HealthStatus
 import io.sdkman.domain.Platform
 import io.sdkman.domain.UniqueVersion
 import io.sdkman.domain.Version
-import io.sdkman.repos.HealthRepositoryImpl
+import io.sdkman.domain.HealthRepository
 import io.sdkman.repos.VersionsRepository
 import io.sdkman.validation.VersionValidator
 import kotlinx.serialization.Serializable
@@ -29,10 +29,7 @@ data class HealthCheckResponse(
     val message: String? = null
 )
 
-//TODO: Inject HealthRepository by interface
-fun Application.configureRouting(repo: VersionsRepository) {
-    //TODO: use dependency injection like VersionRepository
-    val healthRepo = HealthRepositoryImpl()
+fun Application.configureRouting(repo: VersionsRepository, healthRepo: HealthRepository) {
 
     fun ApplicationRequest.visibleQueryParam(): Option<Boolean> =
         when (this.queryParameters["visible"].toOption()) {

src/test/kotlin/io/sdkman/HealthCheckApiSpec.kt

@@ -16,6 +16,7 @@ import io.sdkman.plugins.HealthCheckResponse
 import io.sdkman.plugins.configureDatabase
 import io.sdkman.plugins.configureRouting
 import io.sdkman.repos.VersionsRepository
+import io.sdkman.repos.HealthRepositoryImpl
 import io.sdkman.support.withCleanDatabase
 import kotlinx.serialization.json.Json
 import org.junit.jupiter.api.fail
@@ -28,7 +29,7 @@ class HealthCheckApiSpec : ShouldSpec({
                 application {
                     val dbConfig = configureAppConfig(environment).databaseConfig
                     configureDatabase(dbConfig)
-                    configureRouting(VersionsRepository())
+                    configureRouting(VersionsRepository(), HealthRepositoryImpl())
                 }
 
                 client.get("/meta/health").apply {
@@ -50,7 +51,7 @@ class HealthCheckApiSpec : ShouldSpec({
                 val dbConfig = configureAppConfig(environment).databaseConfig
                 val badDbConfig = dbConfig.copy(port = 9999)
                 configureDatabase(badDbConfig)
-                configureRouting(VersionsRepository())
+                configureRouting(VersionsRepository(), HealthRepositoryImpl())
             }
 
             client.get("/meta/health").apply {

src/test/kotlin/io/sdkman/support/Application.kt

@@ -5,13 +5,14 @@ import io.sdkman.config.configureAppConfig
 import io.sdkman.plugins.configureDatabase
 import io.sdkman.plugins.configureRouting
 import io.sdkman.repos.VersionsRepository
+import io.sdkman.repos.HealthRepositoryImpl
 
 fun withTestApplication(fn: suspend (ApplicationTestBuilder.() -> Unit)) {
     testApplication {
         application {
             val dbConfig = configureAppConfig(environment).databaseConfig
             configureDatabase(dbConfig)
-            configureRouting(VersionsRepository())
+            configureRouting(VersionsRepository(), HealthRepositoryImpl())
         }
         fn(this)
     }