Fix: DHCPv6_am returns Reply instead of Solicit for DHCP6_Request

Author: AbhishekPandey1998

scapy/layers/dhcp6.py

@@ -1875,7 +1875,7 @@ def _include_options(query, answer):
             client_duid = p[DHCP6OptClientId].duid
             resp = IPv6(src=self.src_addr, dst=req_src)
             resp /= UDP(sport=547, dport=546)
-            resp /= DHCP6_Solicit(trid=trid)
+            resp /= DHCP6_Reply(trid=trid)
             resp /= DHCP6OptServerId(duid=self.duid)
             resp /= DHCP6OptClientId(duid=client_duid)
 

test/scapy/layers/dhcp6.uts

@@ -1626,3 +1626,15 @@ a.sport == 546 and a.dport == 547
 = DHCP6_AddrRegReply - Dispatch based on UDP port
 a=UDP(raw(UDP()/DHCP6_AddrRegReply()))
 isinstance(a.payload, DHCP6_AddrRegReply)
+
+############
+############
++ DHCP6_Reply - make_reply generates DHCP6_Reply and not DHCP6_Solicit in response to DHCP6_Request
+
+= DHCP6_Reply - Test that make_reply generates DHCP6_Reply and not DHCP6_Solicit in response to DHCP6_Request
+req = IPv6(src="fe80::1", dst="ff02::1:2")/UDP(sport=546, dport=547)/DHCP6_Request(trid=1)/DHCP6OptClientId(duid=2)
+am = DHCPv6_am()
+am.src_addr = "fe80::2"
+am.duid = 3
+reply = am.make_reply(req)
+reply.haslayer(DHCP6_Reply) and not reply.haslayer(DHCP6_Solicit)