Skip to content

Commit d4ef68a

Browse files
AnkitSegmentpaco-walkmevaradarajan-twGhassenRjab
authored
[stage] Startconn 2841 (#779)
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
1 parent 8399f05 commit d4ef68a

File tree

7 files changed

+18
-9
lines changed

7 files changed

+18
-9
lines changed

integrations/madkudu/lib/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ var integration = require('@segment/analytics.js-integration');
1010
* UMD?
1111
*/
1212

13-
var umd = typeof window.define === 'function' && window.define.amd;
13+
var umd = typeof window.define === 'function' && window.define.amd && window.require;
1414

1515
/**
1616
* Expose `Madkudu` integration.

integrations/madkudu/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-madkudu",
33
"description": "The Madkudu analytics.js integration.",
4-
"version": "2.0.1",
4+
"version": "2.0.2",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",

integrations/pinterest-tag/lib/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,8 @@ Pinterest.prototype.createPropertyMapping = function() {
117117
order_id: 'order_id',
118118
coupon: 'coupon',
119119
value: 'value',
120-
currency: 'currency'
120+
currency: 'currency',
121+
messageId: 'event_id'
121122
};
122123

123124
// This is a second map to allow us to loop over specific potentially-nested properties.

integrations/pinterest-tag/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-pinterest-tag",
33
"description": "The Pinterest Tag analytics.js integration.",
4-
"version": "1.2.3",
4+
"version": "1.2.4",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",

integrations/walkme/lib/index.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ WalkMe.prototype.initialize = function() {
4040

4141
var env = (this.options.environment && this.options.environment.toLowerCase());
4242

43-
if (!env || env == "\/" || env == "\/production") {
43+
if (env === "/" || env === "/production") {
4444
env = "";
4545
}
4646

@@ -71,12 +71,20 @@ WalkMe.prototype.initialize = function() {
7171
var bucket = (this.options.customDirectory) ? this.options.customDirectory : 'users';
7272
var url = 'https://cdn.walkme.com/' + bucket + '/' + walkMeSystemId + '/' + env + '/walkme_' + sriSuffix + walkMeSystemId + '_https.js';
7373

74-
this.load({
74+
var payload = {
7575
url,
7676
hash: this.options.integrityHash
77-
});
77+
};
78+
79+
this.initializeTester(payload);
80+
this.load(payload);
7881
};
7982

83+
/**
84+
* Used for testing initialization
85+
*/
86+
WalkMe.prototype.initializeTester = function () {};
87+
8088
/**
8189
* Has the WalkMe library been loaded yet?
8290
*

integrations/walkme/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@walkme/analytics.js-integration-walkme",
33
"description": "The WalkMe analytics.js integration.",
4-
"version": "1.1.0",
4+
"version": "1.2.1",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",

integrations/walkme/test/index.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,4 +238,4 @@ describe('WalkMe', function() {
238238
}).timeout(10000);
239239
});
240240
});
241-
});
241+
});

0 commit comments

Comments
 (0)