Skip to content

Commit a971b42

Browse files
plbossarttiwai
authored andcommitted
ALSA: atmel: ac97: clarify operator precedence
Fix cppcheck warnings: sound/atmel/ac97c.c:478:30: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] casr & AC97C_CSR_OVRUN ? " OVRUN" : "", ^ sound/atmel/ac97c.c:479:30: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] casr & AC97C_CSR_RXRDY ? " RXRDY" : "", ^ sound/atmel/ac97c.c:480:30: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] casr & AC97C_CSR_UNRUN ? " UNRUN" : "", ^ sound/atmel/ac97c.c:481:30: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] casr & AC97C_CSR_TXEMPTY ? " TXEMPTY" : "", ^ sound/atmel/ac97c.c:482:30: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] casr & AC97C_CSR_TXRDY ? " TXRDY" : "", ^ sound/atmel/ac97c.c:524:30: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] cosr & AC97C_CSR_OVRUN ? " OVRUN" : "", ^ sound/atmel/ac97c.c:525:30: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] cosr & AC97C_CSR_RXRDY ? " RXRDY" : "", ^ sound/atmel/ac97c.c:526:30: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] cosr & AC97C_CSR_TXEMPTY ? " TXEMPTY" : "", ^ sound/atmel/ac97c.c:527:30: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] cosr & AC97C_CSR_TXRDY ? " TXRDY" : "", ^ Signed-off-by: Pierre-Louis Bossart <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 2d7a5c6 commit a971b42

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

sound/atmel/ac97c.c

+11-11
Original file line numberDiff line numberDiff line change
@@ -475,12 +475,12 @@ static irqreturn_t atmel_ac97c_interrupt(int irq, void *dev)
475475
struct snd_pcm_runtime *runtime;
476476
int offset, next_period, block_size;
477477
dev_dbg(&chip->pdev->dev, "channel A event%s%s%s%s%s%s\n",
478-
casr & AC97C_CSR_OVRUN ? " OVRUN" : "",
479-
casr & AC97C_CSR_RXRDY ? " RXRDY" : "",
480-
casr & AC97C_CSR_UNRUN ? " UNRUN" : "",
481-
casr & AC97C_CSR_TXEMPTY ? " TXEMPTY" : "",
482-
casr & AC97C_CSR_TXRDY ? " TXRDY" : "",
483-
!casr ? " NONE" : "");
478+
(casr & AC97C_CSR_OVRUN) ? " OVRUN" : "",
479+
(casr & AC97C_CSR_RXRDY) ? " RXRDY" : "",
480+
(casr & AC97C_CSR_UNRUN) ? " UNRUN" : "",
481+
(casr & AC97C_CSR_TXEMPTY) ? " TXEMPTY" : "",
482+
(casr & AC97C_CSR_TXRDY) ? " TXRDY" : "",
483+
!casr ? " NONE" : "");
484484
if ((casr & camr) & AC97C_CSR_ENDTX) {
485485
runtime = chip->playback_substream->runtime;
486486
block_size = frames_to_bytes(runtime, runtime->period_size);
@@ -521,11 +521,11 @@ static irqreturn_t atmel_ac97c_interrupt(int irq, void *dev)
521521

522522
if (sr & AC97C_SR_COEVT) {
523523
dev_info(&chip->pdev->dev, "codec channel event%s%s%s%s%s\n",
524-
cosr & AC97C_CSR_OVRUN ? " OVRUN" : "",
525-
cosr & AC97C_CSR_RXRDY ? " RXRDY" : "",
526-
cosr & AC97C_CSR_TXEMPTY ? " TXEMPTY" : "",
527-
cosr & AC97C_CSR_TXRDY ? " TXRDY" : "",
528-
!cosr ? " NONE" : "");
524+
(cosr & AC97C_CSR_OVRUN) ? " OVRUN" : "",
525+
(cosr & AC97C_CSR_RXRDY) ? " RXRDY" : "",
526+
(cosr & AC97C_CSR_TXEMPTY) ? " TXEMPTY" : "",
527+
(cosr & AC97C_CSR_TXRDY) ? " TXRDY" : "",
528+
!cosr ? " NONE" : "");
529529
retval = IRQ_HANDLED;
530530
}
531531

0 commit comments

Comments
 (0)