fix: account for rare situation where npme is not returning 404 for not found packages

Closes #1

Author: boennemann

src/index.js

@@ -5,12 +5,21 @@ const RegClient = require('npm-registry-client')
 
 module.exports = function (pluginConfig, {pkg, npm, plugins}, cb) {
   npmlog.level = npm.loglevel || 'warn'
-  const client = new RegClient({log: npmlog})
+  let clientConfig = {log: npmlog}
+  // disable retries for tests
+  if (pluginConfig.retry) clientConfig.retry = pluginConfig.retry
+  const client = new RegClient(clientConfig)
 
   client.get(`${npm.registry}${pkg.name.replace('/', '%2F')}`, {
     auth: npm.auth
   }, (err, data) => {
-    if (err && err.statusCode === 404) return cb(null, {})
+    if (err && (
+      err.statusCode === 404 ||
+      /not found/i.test(err.message)
+    )) {
+      return cb(null, {})
+    }
+
     if (err) return cb(err)
 
     const version = data['dist-tags'][npm.tag]

test/mocks/registry.js

@@ -28,3 +28,6 @@ module.exports = nock('http://registry.npmjs.org')
   .reply(404, {})
   .get('/unavailable-no-body')
   .reply(404)
+  .get('/unavailable-no-404')
+  .times(2)
+  .replyWithError({message: 'not found', statusCode: 500, code: 'E500'})

test/specs/index.js

@@ -67,22 +67,39 @@ test('last release from registry', (t) => {
   })
 
   t.test('get nothing from not yet published package name', (tt) => {
-    tt.plan(4)
+    tt.plan(3)
 
-    lastRelease({}, {
-      pkg: {name: 'unavailable'},
-      npm
-    }, (err, release) => {
-      tt.error(err)
-      tt.is(release.version, undefined, 'no version')
+    tt.test('unavailable', (ttt) => {
+      lastRelease({}, {
+        pkg: {name: 'unavailable'},
+        npm
+      }, (err, release) => {
+        ttt.error(err)
+        ttt.is(release.version, undefined, 'no version')
+        ttt.end()
+      })
     })
 
-    lastRelease({}, {
-      pkg: {name: 'unavailable-no-body'},
-      npm
-    }, (err, release) => {
-      tt.error(err)
-      tt.is(release.version, undefined, 'no version')
+    tt.test('unavailable w/o response body', (ttt) => {
+      lastRelease({}, {
+        pkg: {name: 'unavailable-no-body'},
+        npm
+      }, (err, release) => {
+        ttt.error(err)
+        ttt.is(release.version, undefined, 'no version')
+        ttt.end()
+      })
+    })
+
+    tt.test('unavailable w/o status code', (ttt) => {
+      lastRelease({retry: {count: 1, factor: 1, minTimeout: 1, maxTimeout: 2}}, {
+        pkg: {name: 'unavailable-no-404'},
+        npm
+      }, (err, release) => {
+        ttt.error(err)
+        ttt.is(release.version, undefined, 'no version')
+        ttt.end()
+      })
     })
   })
 })