fix(schedule): null pointer

Author: fiftin

api/projects/tasks.go

@@ -407,3 +407,7 @@ func GetTaskStats(w http.ResponseWriter, r *http.Request) {
 
 	helpers.WriteJSON(w, http.StatusOK, stats)
 }
+
+func StopAllTasks(w http.ResponseWriter, r *http.Request) {
+	w.WriteHeader(http.StatusNoContent)
+}

api/router.go

@@ -423,6 +423,7 @@ func Route(
 	projectTmplManagement.HandleFunc("/{template_id}/tasks/last", projects.GetLastTasks).Methods("GET")
 	projectTmplManagement.HandleFunc("/{template_id}/schedules", projects.GetTemplateSchedules).Methods("GET")
 	projectTmplManagement.HandleFunc("/{template_id}/stats", projects.GetTaskStats).Methods("GET")
+	projectTmplManagement.HandleFunc("/{template_id}/stop_all_tasks", projects.StopAllTasks).Methods("POST")
 
 	projectTmplInvManagement := projectTmplManagement.PathPrefix("/{template_id}/inventory").Subrouter()
 	projectTmplInvManagement.Use(projects.InventoryMiddleware)

db/Schedule.go

@@ -11,8 +11,8 @@ type Schedule struct {
 	LastCommitHash *string `db:"last_commit_hash" json:"-" backup:"-"`
 	RepositoryID   *int    `db:"repository_id" json:"repository_id" backup:"-"`
 
-	TaskParamsID *int        `db:"task_params_id" json:"-" backup:"-"`
-	TaskParams   *TaskParams `db:"-" json:"task_params,omitempty" backup:"task_params"`
+	TaskParamsID *int       `db:"task_params_id" json:"-" backup:"-"`
+	TaskParams   TaskParams `db:"-" json:"task_params,omitempty" backup:"task_params"`
 }
 
 type ScheduleWithTpl struct {

db/sql/schedule.go

@@ -7,8 +7,8 @@ import (
 
 func (d *SqlDb) CreateSchedule(schedule db.Schedule) (newSchedule db.Schedule, err error) {
 
-	if schedule.TaskParams != nil {
-		params := *schedule.TaskParams
+	if schedule.TaskParamsID != nil {
+		params := schedule.TaskParams
 		params.ProjectID = schedule.ProjectID
 		err = d.Sql().Insert(&params)
 		if err != nil {
@@ -51,14 +51,14 @@ func (d *SqlDb) SetScheduleLastCommitHash(projectID int, scheduleID int, lastCom
 
 func (d *SqlDb) UpdateSchedule(schedule db.Schedule) (err error) {
 
-	if schedule.TaskParams != nil {
+	if schedule.TaskParamsID != nil {
 		var curr db.Schedule
 		err = d.getObject(schedule.ProjectID, db.ScheduleProps, schedule.ID, &curr)
 		if err != nil {
 			return
 		}
 
-		params := *schedule.TaskParams
+		params := schedule.TaskParams
 		params.ProjectID = schedule.ProjectID
 
 		if curr.TaskParamsID == nil {
@@ -114,7 +114,7 @@ func (d *SqlDb) GetSchedule(projectID int, scheduleID int) (schedule db.Schedule
 			return
 		}
 
-		schedule.TaskParams = &taskParams
+		schedule.TaskParams = taskParams
 	}
 
 	return
@@ -162,7 +162,7 @@ func (d *SqlDb) GetProjectSchedules(projectID int, includeTaskParams bool) (sche
 			if err != nil {
 				return nil, err
 			}
-			schedules[i].TaskParams = &taskParams
+			schedules[i].TaskParams = taskParams
 		}
 	}
 

services/project/backup.go

@@ -234,7 +234,7 @@ func (b *BackupDB) format() (*BackupFormat, error) {
 			*tplName,
 		}
 
-		if o.TaskParams != nil && o.TaskParams.InventoryID != nil {
+		if o.TaskParams.InventoryID != nil {
 			schedules[i].TaskParams.InventoryName, _ = findNameByID[db.Inventory](*o.TaskParams.InventoryID, b.inventories)
 		}
 	}

services/project/restore.go

@@ -91,12 +91,12 @@ func (e BackupSchedule) Restore(store db.Store, b *BackupDB) error {
 	}
 	v.TemplateID = tpl.ID
 
-	if v.TaskParams != nil {
-		inv := findEntityByName[db.Inventory](e.TaskParams.InventoryName, b.inventories)
-		if inv != nil {
-			v.TaskParams.InventoryID = &inv.ID
-		}
+	//if v.TaskParams != nil {
+	inv := findEntityByName[db.Inventory](e.TaskParams.InventoryName, b.inventories)
+	if inv != nil {
+		v.TaskParams.InventoryID = &inv.ID
 	}
+	//}
 
 	newSchedule, err := store.CreateSchedule(v)
 	if err != nil {