Skip to content

Commit 4c0d890

Browse files
committed
cleanup, fix remove eventlisteners
1 parent 3b7ba44 commit 4c0d890

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.storybook/preview.js

+1
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@ export const parameters = {
66
date: /Date$/,
77
},
88
},
9+
layout: "fullscreen",
910
};

src/hooks/useFreeEditor.js

+5-6
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const useFreeEditor = (boxRef, headerRef) => {
2828
window.addEventListener("mousemove", mousemoveHandle);
2929
window.addEventListener("mouseup", () => {
3030
window.removeEventListener("mousemove", mousemoveHandle);
31-
});
31+
}, {once: true});
3232
}
3333

3434
function getValidHeight(height) {
@@ -87,12 +87,10 @@ const useFreeEditor = (boxRef, headerRef) => {
8787
};
8888

8989
window.addEventListener("mousemove", mouseMoveHandler);
90-
window.addEventListener("mouseup", mouseUpHandler);
91-
}
90+
window.addEventListener("mouseup", () => {
91+
window.removeEventListener("mousemove", mouseMoveHandler);
9292

93-
function mouseUpHandler() {
94-
window.removeEventListener("mousemove", mouseMoveHandler);
95-
window.removeEventListener("mouseup", mouseUpHandler);
93+
}, {once: true})
9694
}
9795

9896
const mouseMoveHandler = useCallback((e) => {
@@ -139,6 +137,7 @@ const useFreeEditor = (boxRef, headerRef) => {
139137
}
140138
}, [isDocked]);
141139

140+
142141
return {
143142
editorPosition,
144143
editorSize,

0 commit comments

Comments
 (0)