Implement Copy and Clone for Handle<T> where T: !Copy (#563)

gmorenz · web-flow · commit 39db84352d79 · 2025-03-23T15:13:23.000Z
Signed-off-by: Greg Morenz &lt;greg-morenz@droid.cafe&gt;
diff --git a/mozjs/src/gc/root.rs b/mozjs/src/gc/root.rs
@@ -100,11 +100,18 @@ impl<'a, const N: usize> From<&RootedGuard<'a, ValueArray<N>>> for JS::HandleVal
     }
 }
 
-#[derive(Clone, Copy)]
 pub struct Handle<'a, T: 'a> {
     pub(crate) ptr: &'a T,
 }
 
+impl<T> Clone for Handle<'_, T> {
+    fn clone(&self) -> Self {
+        *self
+    }
+}
+
+impl<T> Copy for Handle<'_, T> {}
+
 pub struct MutableHandle<'a, T: 'a> {
     pub(crate) ptr: *mut T,
     anchor: PhantomData<&'a mut T>,

Original file line number	Diff line number	Diff line change
`@@ -100,11 +100,18 @@ impl<'a, const N: usize> From<&RootedGuard<'a, ValueArray<N>>> for JS::HandleVal`
`100`	`100`	`}`
`101`	`101`	`}`
`102`	`102`
`103`		`-#[derive(Clone, Copy)]`
`104`	`103`	`pub struct Handle<'a, T: 'a> {`
`105`	`104`	`pub(crate) ptr: &'a T,`
`106`	`105`	`}`
`107`	`106`
	`107`	`+impl<T> Clone for Handle<'_, T> {`
	`108`	`+ fn clone(&self) -> Self {`
	`109`	`+ *self`
	`110`	`+ }`
	`111`	`+}`
	`112`	`+`
	`113`	`+impl<T> Copy for Handle<'_, T> {}`
	`114`	`+`
`108`	`115`	`pub struct MutableHandle<'a, T: 'a> {`
`109`	`116`	`pub(crate) ptr: *mut T,`
`110`	`117`	`anchor: PhantomData<&'a mut T>,`