-
Notifications
You must be signed in to change notification settings - Fork 230
Upgrade usvg from 0.9 -> 0.20 #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Just realized #487 does mostly the same thing, I didn't notice since it has a different name. I believe my changes fixed a couple more things than it, but I'm not 100% sure. |
|
A rebase might be a good idea, up to you. As for |
|
☔ The latest upstream changes (presumably #491) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@kognise Do you have any time to work on this? |
|
Sorry, I'll try to handle it by Monday at the latest. |
|
Trying to get these PRs working... I'm stuck on an M1 MacBook right now, which is normally a blessing! I'm having trouble with the Even after upgrading Winit in all of Pathfinder, Surfman still depends on the older version. What's the best way to handle this? Should I make a PR to Surfman and wait for that to merge, then come back here? Thanks! |
|
I'd like to combine changes from this PR into #487 if you don't mind. As as result, this one will be superseded. |
Upgrades
usvgto 0.20. Had to make some minor code changes, the main differences are:Treeconstructors now take anOptionsRefinstead of anOptions, so we need a bunch of.to_ref()callsTree::from_filewas removed, I replaced it withTree::from_dataandstd::fs::read