Skip to content

Commit 91b16c0

Browse files
authored
[Plot] Revert grid alpha and add TODOs (#67)
1 parent c9aca7b commit 91b16c0

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

genai_bench/analysis/flexible_plot_report.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ def _plot_multi_line_metric(
481481
ax.set_xlabel(plot_spec.x_label or self._generate_label(plot_spec.x_field))
482482
ax.set_ylabel(plot_spec.y_label or "Value")
483483
ax.set_title(plot_spec.title)
484-
ax.grid(True, alpha=0.1)
484+
ax.grid(True, alpha=0.3)
485485

486486
# Position legend outside plot area for multi-line plots to avoid overlap
487487
ax.legend(bbox_to_anchor=(1.05, 1), loc="upper left", fontsize="small")
@@ -593,7 +593,7 @@ def _save_individual_subplots_multiline(
593593
# Copy grid
594594
ax_temp.grid(
595595
ax.get_xgridlines()[0].get_visible() if ax.get_xgridlines() else True,
596-
alpha=0.1,
596+
alpha=0.3,
597597
)
598598
ax_temp.minorticks_on()
599599

genai_bench/analysis/plot_report.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,7 @@ def plot_metrics(
278278
)
279279

280280

281+
# TODO: Remove this function when flexible plot report is fully tested.
281282
def plot_experiment_data(
282283
run_data_list: List[Tuple[ExperimentMetadata, ExperimentMetrics]],
283284
group_key: str,

0 commit comments

Comments
 (0)