Skip to content

Commit 56ec2ec

Browse files
committed
Correct process wrt owners
1 parent 47eadef commit 56ec2ec

File tree

1 file changed

+13
-16
lines changed

1 file changed

+13
-16
lines changed

community/index.md

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -72,33 +72,30 @@ intro_image_hide_on_mobile: false
7272
reviewers who are
7373
familiar with the area of code you are touching. If you have doubts, look at the git blame for the
7474
file and the
75-
CODEOWNER file.
75+
CODEOWNERS file.
7676
</p>
7777
<p>
7878
Submissions to <a
7979
href="https://github.com/shader-slang/spec/tree/master/proposals">/proposals/ in the spec repository</a>
80-
are considered <strong>Slang Proposed Features</strong> (SPFs), and require two <strong>Language
81-
Owners</strong> (more info
80+
are considered <strong>Slang Proposed Features</strong> (SPFs), and require a <strong>Language
81+
Owner</strong> (more info
8282
below) to approve the submission.</p>
8383
<h4>Owner</h4>
8484
<p>
85-
Every file in the Slang repository has a list of owners. An owner of a directory has the right to
86-
approve pull requests
87-
touching the directory. A pull request is approved only when at least two owners of each directory
88-
affected by the
89-
changes have given their approval. If you are a committer and think you're ready to become an owner
90-
of a directory, put
91-
up a PR to the relevant OWNERs and get two owners to review it. In case of conflict between owners,
92-
owners need to reach
93-
consensus amongst themselves.</p>
85+
An owner of a directory in the Slang repository has the right to
86+
approve pull requests touching the directory.
87+
A pull request is approved only when at least one owner of each directory
88+
affected by the changes have given their approval. Currently all members of <a
89+
href="https://github.com/orgs/shader-slang/teams/dev">shader-slang/dev</a> are owners
90+
of every directory. </p>
9491
<p>
9592
<strong>Language Owner</strong>: A language owner is the owner of the <a
9693
href="https://github.com/shader-slang/spec/tree/master/proposals">proposals in the spec repository</a>. All
9794
new Slang language and core module
9895
features (e.g. new language syntax, new functions, or new types in the Slang core module) starts
9996
with a design document
100-
submitted to this directory. The language and core module design must be approved by two language
101-
owners before any
97+
submitted to this directory. The language and core module design must be approved by a language
98+
owner before any
10299
implementation pull request for the new language feature can be approved.
103100
</p>
104101
</div>
@@ -118,8 +115,8 @@ intro_image_hide_on_mobile: false
118115
A bug fix starts with a GitHub issue describing the bug. Any community member can submit a pull
119116
request coming from your
120117
personal fork of Slang containing fixes for the bug. Such pull requests needs to be reviewed and
121-
approved by two
122-
committers who are owners of the files being changed by the pull request. Once the pull request is
118+
approved by a
119+
committer who is familiar the files being changed by the pull request. Once the pull request is
123120
approved and has
124121
passed all CI tests, it can be merged to the main branch. Pull requests are expected to be reviewed
125122
by the committers within 24 hours after they are created or updated, and to

0 commit comments

Comments
 (0)