linting

Author: AbanoubGhadban

node_package/src/RSCClientRoot.ts

@@ -7,7 +7,7 @@ import * as ReactDOMClient from 'react-dom/client';
 import { createFromReadableStream } from 'react-on-rails-rsc/client';
 import { fetch } from './utils';
 import transformRSCStreamAndReplayConsoleLogs from './transformRSCStreamAndReplayConsoleLogs';
-import { RailsContext, RenderFunction } from './types';
+import { RailsContext, RenderFunction, RenderResult } from './types';
 
 const { use } = React;
 
@@ -44,14 +44,14 @@ const fetchRSC = ({ componentName, rscPayloadGenerationUrlPath, componentProps }
 };
 
 const createRSCStreamFromPage = () => {
-  let streamController: ReadableStreamController<unknown> | undefined;
-  const stream = new ReadableStream({
+  let streamController: ReadableStreamController<RenderResult> | undefined;
+  const stream = new ReadableStream<RenderResult>({
     start(controller) {
       if (typeof window === 'undefined') {
         return;
       }
       const handleChunk = (chunk: unknown) => {
-        controller.enqueue(chunk);
+        controller.enqueue(chunk as RenderResult);
       };
       if (!window.__FLIGHT_DATA) {
         window.__FLIGHT_DATA = [];

node_package/src/RSCPayloadContainer.ts

@@ -50,7 +50,7 @@ export default function RSCPayloadContainerWrapper({ RSCPayloadStream }: RSCPayl
   const [chunkPromises] = React.useState<Promise<StreamChunk>[]>(() => {
     const promises: Promise<StreamChunk>[] = [];
     let resolveCurrentPromise: (streamChunk: StreamChunk) => void = () => {};
-    let rejectCurrentPromise: (error: Error) => void = () => {};
+    let rejectCurrentPromise: (error: unknown) => void = () => {};
     const decoder = new TextDecoder();
 
     const createNewPromise = () => {
@@ -64,7 +64,7 @@ export default function RSCPayloadContainerWrapper({ RSCPayloadStream }: RSCPayl
 
     createNewPromise();
     RSCPayloadStream.on('data', (streamChunk) => {
-      resolveCurrentPromise({ chunk: decoder.decode(streamChunk), isLastChunk: false });
+      resolveCurrentPromise({ chunk: decoder.decode(streamChunk as Uint8Array), isLastChunk: false });
       createNewPromise();
     });
 

node_package/src/RSCServerRoot.ts

@@ -1,10 +1,10 @@
 import * as React from 'react';
 import { createFromNodeStream } from 'react-on-rails-rsc/client.node';
+import { PassThrough } from 'stream';
 import type { RenderFunction, RailsContext } from './types';
 import transformRSCStream from './transformRSCNodeStreamAndReplayConsoleLogs';
 import loadJsonFile from './loadJsonFile';
 import RSCPayloadContainer from './RSCPayloadContainer';
-import { PassThrough } from 'stream';
 
 declare global {
   function generateRSCPayload(

node_package/src/ReactOnRails.client.ts

@@ -195,7 +195,7 @@ ctx.ReactOnRails = {
   },
 
   resetOptions(): void {
-    this.options = Object.assign({}, DEFAULT_OPTIONS);
+    this.options = { ...DEFAULT_OPTIONS };
   },
 
   isRSCBundle: false,

node_package/src/loadJsonFile.ts

@@ -15,7 +15,7 @@ export default async function loadJsonFile(fileName: string) {
   }
 
   try {
-    const file = JSON.parse(await fs.readFile(filePath, 'utf8'));
+    const file = JSON.parse(await fs.readFile(filePath, 'utf8')) as LoadedJsonFile;
     loadedJsonFiles.set(filePath, file);
     return file;
   } catch (error) {

node_package/src/registerServerComponent/server.ts

@@ -31,7 +31,7 @@ const registerServerComponent = (components: Record<string, ReactComponent>) =>
       railsContext?: RailsContext,
     ) => RSCServerRoot({ componentName, componentProps }, railsContext);
   }
-  return ReactOnRails.register(componentsWrappedInRSCServerRoot);
+  ReactOnRails.register(componentsWrappedInRSCServerRoot);
 };
 
 export default registerServerComponent;

node_package/src/transformRSCNodeStreamAndReplayConsoleLogs.ts

@@ -7,7 +7,7 @@ export default function transformRSCStream(stream: NodeJS.ReadableStream): NodeJ
   const htmlExtractor = new Transform({
     transform(oneOrMoreChunks, _, callback) {
       try {
-        const decodedChunk = lastIncompleteChunk + decoder.decode(oneOrMoreChunks);
+        const decodedChunk = lastIncompleteChunk + decoder.decode(oneOrMoreChunks as Uint8Array);
         const separateChunks = decodedChunk.split('\n').filter((chunk) => chunk.trim() !== '');
 
         if (!decodedChunk.endsWith('\n')) {
@@ -27,11 +27,5 @@ export default function transformRSCStream(stream: NodeJS.ReadableStream): NodeJ
     },
   });
 
-  try {
-    return stream.pipe(htmlExtractor);
-  } catch (error) {
-    throw new Error(
-      `Error transforming RSC stream (${stream.constructor.name}), (stream: ${stream}), stringified stream: ${JSON.stringify(stream)}, error: ${error}`,
-    );
-  }
+  return stream.pipe(htmlExtractor);
 }