Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Pronouns.page (#2418) #2419

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Si-ddhartha
Copy link

@Si-ddhartha Si-ddhartha commented Mar 4, 2025

This PR closes #2418 by adding support for pronouns.page to Sherlock.

@wrac4242
Copy link

wrac4242 commented Mar 4, 2025

that would only check the en locale, which not all accounts have. potentially remove the en. from the domain to check the list of locales

@wrac4242
Copy link

wrac4242 commented Mar 4, 2025

actually no it would work, just come up with a list of locales they have setup

@Si-ddhartha
Copy link
Author

Yeah @wrac4242, you're absolutely right! When I first visited the site, I chose English and completely overlooked the fact that there are multiple language options. That was my mistake.
I'll look into how I can support all available locales as well. Thanks for pointing it out!

@wrac4242
Copy link

wrac4242 commented Mar 4, 2025

it was my mistake there, you can still check the en. page, it just comes with a list of other locales that exist for the user account

@Si-ddhartha
Copy link
Author

Si-ddhartha commented Mar 5, 2025

I think using this link would be a better approach since it lists all the locales available for the user account. What do you think @wrac4242

@wrac4242
Copy link

wrac4242 commented Mar 5, 2025

that link should be better yea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requesting support for: pronouns.page
2 participants