-
Notifications
You must be signed in to change notification settings - Fork 0
Yoel highscore prompt for name and update #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
You also need to update the level and lines stats when saving high score. |
…etris-game-controller into yoel-highscore-display
@shuki25 It is updated and scored in the One thing I was missing was the lines, but I added that just now. |
|
Convert _ to space. I noticed _ was saved when viewing high score. You can view high score list from menu after game end and after entering your name. Press start to show menu. |
|
You can't return -1 to a uint8_t data type (it's a non-signed 8 bit integer). |
What should I return then? |
Nevermind, resolved... |

Closes #114