Skip to content

Conversation

@yoelbuzgalo
Copy link
Collaborator

Closes #114

@yoelbuzgalo yoelbuzgalo requested a review from shuki25 April 22, 2025 20:40
@yoelbuzgalo yoelbuzgalo added the enhancement New feature or request label Apr 22, 2025
Copy link
Owner

@shuki25 shuki25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Must be warning free. Fix it.

Change it to high_score[i]->score. Add default return statement after for loop exits. What if no match found, then what?

@shuki25
Copy link
Owner

shuki25 commented Apr 22, 2025

You also need to update the level and lines stats when saving high score.

@yoelbuzgalo
Copy link
Collaborator Author

yoelbuzgalo commented Apr 23, 2025

You also need to update the level and lines stats when saving high score.

@shuki25 It is updated and scored in the ui_get_initials_high_score function (lines 471 to 472)

One thing I was missing was the lines, but I added that just now.

@yoelbuzgalo yoelbuzgalo requested a review from shuki25 April 23, 2025 00:10
@shuki25
Copy link
Owner

shuki25 commented Apr 23, 2025

Convert _ to space. I noticed _ was saved when viewing high score. You can view high score list from menu after game end and after entering your name. Press start to show menu.

@shuki25
Copy link
Owner

shuki25 commented Apr 23, 2025

You can't return -1 to a uint8_t data type (it's a non-signed 8 bit integer).

@yoelbuzgalo
Copy link
Collaborator Author

You can't return -1 to a uint8_t data type (it's a non-signed 8 bit integer).

What should I return then?

@yoelbuzgalo
Copy link
Collaborator Author

You can't return -1 to a uint8_t data type (it's a non-signed 8 bit integer).

What should I return then?

Nevermind, resolved...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display high score if applicable, and prompt for name entry

3 participants