Skip to content

Commit e4a8fb0

Browse files
joshkraftgopherbot
authored andcommitted
os: add tests for UserCacheDir and UserConfigDir
Adds basic test scenarios for UserCacheDir and UserConfigDir. Fixes golang#57638 Change-Id: Ieb86e95faff44287bfa13daa0cb26e7b5401373b Reviewed-on: https://go-review.googlesource.com/c/go/+/520262 Run-TryBot: Bryan Mills <[email protected]> TryBot-Bypass: Bryan Mills <[email protected]> Reviewed-by: Matthew Dempsky <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Auto-Submit: Bryan Mills <[email protected]>
1 parent a7c3de7 commit e4a8fb0

File tree

2 files changed

+48
-0
lines changed

2 files changed

+48
-0
lines changed

misc/go_android_exec/main.go

+1
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ func runMain() (int, error) {
204204
`; export GOPROXY=` + os.Getenv("GOPROXY") +
205205
`; export GOCACHE="` + deviceRoot + `/gocache"` +
206206
`; export PATH="` + deviceGoroot + `/bin":$PATH` +
207+
`; export HOME="` + deviceRoot + `/home"` +
207208
`; cd "` + deviceCwd + `"` +
208209
"; '" + deviceBin + "' " + strings.Join(os.Args[2:], " ")
209210
code, err := adbRun(cmd)

src/os/os_test.go

+47
Original file line numberDiff line numberDiff line change
@@ -2823,6 +2823,53 @@ func TestDoubleCloseError(t *testing.T) {
28232823
t.Run("dir", testDoubleCloseError(sfdir))
28242824
}
28252825

2826+
func TestUserCacheDir(t *testing.T) {
2827+
t.Parallel()
2828+
2829+
dir, err := UserCacheDir()
2830+
if err != nil {
2831+
t.Skipf("skipping: %v", err)
2832+
}
2833+
if dir == "" {
2834+
t.Fatalf("UserCacheDir returned %q; want non-empty path or error", dir)
2835+
}
2836+
2837+
if err := MkdirAll(dir, 0777); err != nil {
2838+
t.Fatalf("could not create UserCacheDir: %v", err)
2839+
}
2840+
d, err := MkdirTemp(dir, "TestUserCacheDir")
2841+
if err != nil {
2842+
t.Fatalf("could not create a directory in UserCacheDir: %v", err)
2843+
}
2844+
if err := Remove(d); err != nil {
2845+
t.Fatal(err)
2846+
}
2847+
}
2848+
2849+
func TestUserConfigDir(t *testing.T) {
2850+
t.Parallel()
2851+
2852+
dir, err := UserConfigDir()
2853+
if err != nil {
2854+
t.Skipf("skipping: %v", err)
2855+
}
2856+
if dir == "" {
2857+
t.Fatalf("UserConfigDir returned %q; want non-empty path or error", dir)
2858+
}
2859+
2860+
if err := MkdirAll(dir, 0777); err != nil {
2861+
t.Fatalf("could not create UserConfigDir: %v", err)
2862+
}
2863+
2864+
d, err := MkdirTemp(dir, "TestUserConfigDir")
2865+
if err != nil {
2866+
t.Fatalf("could not create a directory in UserConfigDir: %v", err)
2867+
}
2868+
if err := Remove(d); err != nil {
2869+
t.Fatal(err)
2870+
}
2871+
}
2872+
28262873
func TestUserHomeDir(t *testing.T) {
28272874
t.Parallel()
28282875

0 commit comments

Comments
 (0)