Fix bad active state check for subscriptions.

Author: alex-signal

libsignal-service/src/main/java/org/whispersystems/signalservice/api/subscriptions/ActiveSubscription.java

@@ -137,7 +137,7 @@ public boolean isPendingBankTransfer() {
   }
 
   public boolean isInProgress() {
-    return !isActive() && (!isFailedPayment() || isPastDue()) && !isCanceled();
+    return activeSubscription != null && !isActive() && (!isFailedPayment() || isPastDue()) && !isCanceled();
   }
 
   public boolean isPastDue() {

libsignal-service/src/test/java/org/whispersystems/signalservice/api/subscriptions/ActiveSubscriptionTest.java

@@ -15,4 +15,11 @@ public void givenActiveSubscription_whenIIsPaymentFailure_thenIExpectFalse() thr
     assertTrue(activeSubscription.isActive());
     assertFalse(activeSubscription.isFailedPayment());
   }
+
+  @Test
+  public void givenNoActiveSubscription_whenIIsInProgress_thenIExpectFalse() throws Exception {
+    ActiveSubscription activeSubscription = new ActiveSubscription(null, null);
+
+    assertFalse(activeSubscription.isInProgress());
+  }
 }