Upgrade golangci lint to latest (#50)

Signed-off-by: Bogdan Drutu <[email protected]>

Signed-off-by: Bogdan Drutu <[email protected]>

Author: bogdandrutu

.golangci.yml

@@ -159,7 +159,6 @@ linters:
     - asciicheck
     - bodyclose
     - cyclop
-    - deadcode
     - depguard
     - durationcheck
     - errorlint
@@ -192,7 +191,6 @@ linters:
     - predeclared
     - revive
     - staticcheck
-    - structcheck
     - stylecheck
     - testpackage
     - thelper

Makefile

@@ -1,7 +1,7 @@
 SHELL                 = /bin/bash
 BASE                  = $(CURDIR)
 CP_RF                 = cp -rf
-GOLANGCI_LINT_VERSION = 1.20.0
+GOLANGCI_LINT_VERSION = 1.49.0
 
 # enable module support across all go commands.
 export GO111MODULE = on

protocol/collectd/format/format.go

@@ -1,10 +1,12 @@
 package collectdformat
 
 // JSONWriteBody is the full POST body of collectd's write_http format
+//
 //easyjson:json
 type JSONWriteBody []*JSONWriteFormat
 
 // JSONWriteFormat is the format for collectd json datapoints
+//
 //easyjson:json
 type JSONWriteFormat struct {
 	Dsnames        []*string  `json:"dsnames"`

protocol/signalfx/format/signalfx_format.go

@@ -7,6 +7,7 @@ import (
 )
 
 // JSONDatapointV1 is the JSON API format for /v1/datapoint
+//
 //easyjson:json
 type JSONDatapointV1 struct {
 	//easyjson:json
@@ -16,10 +17,12 @@ type JSONDatapointV1 struct {
 }
 
 // JSONDatapointV2 is the V2 json datapoint sending format
+//
 //easyjson:json
 type JSONDatapointV2 map[string][]*BodySendFormatV2
 
 // BodySendFormatV2 is the JSON format signalfx datapoints are expected to be in
+//
 //easyjson:json
 type BodySendFormatV2 struct {
 	Metric     string            `json:"metric"`
@@ -36,10 +39,12 @@ func (bodySendFormat *BodySendFormatV2) String() string {
 type ValueToSend interface{}
 
 // JSONEventV2 is the V2 json event sending format
+//
 //easyjson:json
 type JSONEventV2 []*EventSendFormatV2
 
 // EventSendFormatV2 is the JSON format signalfx datapoints are expected to be in
+//
 //easyjson:json
 type EventSendFormatV2 struct {
 	EventType  string                 `json:"eventType"`
@@ -51,6 +56,7 @@ type EventSendFormatV2 struct {
 
 // InputAnnotation associates an event that explains latency with a timestamp.
 // Unlike log statements, annotations are often codes. Ex. “ws” for WireSend
+//
 //easyjson:json
 type InputAnnotation struct {
 	Endpoint  *trace.Endpoint `json:"endpoint"`
@@ -78,6 +84,7 @@ func GetPointerToInt64(p *float64) *int64 {
 }
 
 // BinaryAnnotation associates an event that explains latency with a timestamp.
+//
 //easyjson:json
 type BinaryAnnotation struct {
 	Endpoint *trace.Endpoint `json:"endpoint"`
@@ -86,6 +93,7 @@ type BinaryAnnotation struct {
 }
 
 // InputSpan defines a span that is the union of v1 and v2 spans
+//
 //easyjson:json
 type InputSpan struct {
 	trace.Span
@@ -96,5 +104,6 @@ type InputSpan struct {
 }
 
 // InputSpanList is an array of InputSpan pointers
+//
 //easyjson:json
 type InputSpanList []*InputSpan

protocol/wavefront/wavefrontlistener.go

@@ -153,7 +153,7 @@ func getMetricPieces(line string) []string {
 }
 
 // https://docs.wavefront.com/wavefront_data_format.html
-//<metricName> <metricValue> [<timestamp>] source=<source> [pointTags]
+// <metricName> <metricValue> [<timestamp>] source=<source> [pointTags]
 func (listener *Listener) fromWavefrontDatapoint(line string) *datapoint.Datapoint {
 	pieces := getMetricPieces(line)
 	if len(pieces) < 3 {