Support Ktor (Okhttp engine)

[ber4444]

We are getting an exception when trying to use it with ktorTelemetry = "io.opentelemetry.instrumentation:opentelemetry-ktor-3.0:2.13.0-alpha":

java.lang.NoClassDefFoundError: Failed resolution of: Lio/opentelemetry/semconv/ResourceAttributes;
	at io.opentelemetry.android.AndroidResource.createDefault(AndroidResource.java:29)
	at io.opentelemetry.android.OpenTelemetryRumBuilder.<init>(OpenTelemetryRumBuilder.java:101)
	at io.opentelemetry.android.OpenTelemetryRum.builder(OpenTelemetryRum.java:46)
	at com.splunk.rum.RumInitializer.initialize(RumInitializer.java:108)
	at com.splunk.rum.SplunkRum.initialize(SplunkRum.java:111)
	at com.splunk.rum.SplunkRumBuilder.build(SplunkRumBuilder.java:348)

Usage should be something like this?

HttpClient(OkHttp) {
      install(KtorClientTelemetry) {
                        setOpenTelemetry(SplunkRum.getInstance().openTelemetry)

[ber4444]

We used to rely on createRumOkHttpCallFactory with Retrofit like so:

val builder = Retrofit.Builder()
...
builder.callFactory(SplunkRum.getInstance().createRumOkHttpCallFactory(httpClient)).build().create()

I saw that the Splunk SDK deprecated createRumOkHttpCallFactory but no replacement is offered.

[surbhiia]

Hi @ber4444, For the first issue where ResourceAttributes class is not found:

java.lang.NoClassDefFoundError: Failed resolution of: Lio/opentelemetry/semconv/ResourceAttributes;
at io.opentelemetry.android.AndroidResource.createDefault(AndroidResource.java:29)
at io.opentelemetry.android.OpenTelemetryRumBuilder.(OpenTelemetryRumBuilder.java:101)
at io.opentelemetry.android.OpenTelemetryRum.builder(OpenTelemetryRum.java:46)
at com.splunk.rum.RumInitializer.initialize(RumInitializer.java:108)
at com.splunk.rum.SplunkRum.initialize(SplunkRum.java:111)
at com.splunk.rum.SplunkRumBuilder.build(SplunkRumBuilder.java:348)

The issue is with the version of opentelemetry-semconv library, the opentelemetry-ktor-3.0 version 2.13.0-alpha is bringing. In newer versions of opentelemetry-semconv the ResourceAttributes class is replaced with other classes. Therefore, opentelemetry-ktor-3.0 version 2.13.0-alpha is not compatible with current versions of splunk-otel-android. This won't be an issue in upcoming versions of splunk-otel-android.

[ber4444]

Please share a code sample showing Ktor integration.

Also please share what's offered to replace createRumOkHttpCallFactory

[SenNeonoveNoci]

Hi @ber4444,

In the next release of the agent, we will introduce a new API and logic for the manual OkHttp instrumentation. It will no longer provide Call.Factory like the current implementation but will work on a slightly different principle.

It will utilize the addNetworkInterceptor(interceptor: Interceptor), which will be used to set a SplunkOkHttpInterceptor that handles all the work.

After the next release, your use case might look something like this:

val builder = Retrofit.Builder()  
...  
httpClient.addNetworkInterceptor(SplunkOkHttpInterceptor())  
builder.client(httpClient).build().create()

Changes:

• Use addNetworkInterceptor(interceptor: Interceptor).
• Use client(client: OkHttpClient) instead of callFactory(factory: Call.Factory).

Sorry for any inconvenience.

[ber4444]

Would KtorClientTelemetry be also supported or we would be forced to use the Okhttp engine with Ktor and configure telemetry with the Okhttp interceptor like you described? That works for us, it's just not supportive of the KMP world.