Skip to content

Commit ea95246

Browse files
committed
rename TODOs
1 parent 76b0330 commit ea95246

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

beacon_node/beacon_chain/src/envelope_verification.rs

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ fn load_snapshot<T: BeaconChainTypes>(
157157
};
158158
drop(fork_choice_read_lock);
159159

160-
// TODO(gloas): add metrics here
160+
// TODO(EIP-7732): add metrics here
161161

162162
let result = {
163163
// Load the parent block's state from the database, returning an error if it is not found.
@@ -167,9 +167,9 @@ fn load_snapshot<T: BeaconChainTypes>(
167167
// prior to the finalized slot (which is invalid and inaccessible in our DB schema).
168168
let (parent_state_root, state) = chain
169169
.store
170-
// TODO(gloas): the state doesn't need to be advanced here because we're applying an envelope
171-
// but this function does use a lot of caches that could be more efficient. Is there
172-
// a better way to do this?
170+
// TODO(EIP-7732): the state doesn't need to be advanced here because we're applying an envelope
171+
// but this function does use a lot of caches that could be more efficient. Is there
172+
// a better way to do this?
173173
.get_advanced_hot_state(
174174
beacon_block_root,
175175
proto_beacon_block.slot,
@@ -225,7 +225,7 @@ impl<T: BeaconChainTypes> GossipVerifiedEnvelope<T> {
225225
let beacon_block_root = envelope.beacon_block_root();
226226

227227
// check that we've seen the parent block of this envelope and that it passes validation
228-
// TODO(gloas): this check would fail if the block didn't pass validation right?
228+
// TODO(EIP-7732): this check would fail if the block didn't pass validation right?
229229
let fork_choice_read_lock = chain.canonical_head.fork_choice_read_lock();
230230
let Some(parent_proto_block) = fork_choice_read_lock.get_block(&beacon_block_root) else {
231231
return Err(EnvelopeError::BlockRootUnknown {
@@ -234,12 +234,12 @@ impl<T: BeaconChainTypes> GossipVerifiedEnvelope<T> {
234234
};
235235
drop(fork_choice_read_lock);
236236

237-
// TODO(gloas): check that we haven't seen another valid `SignedExecutionPayloadEnvelope`
238-
// for this block root from this builder - envelope status table check
237+
// TODO(EIP-7732): check that we haven't seen another valid `SignedExecutionPayloadEnvelope`
238+
// for this block root from this builder - envelope status table check
239239

240-
// TODO(gloas): this should probably be obtained from the ProtoBlock instead of the DB
241-
// but this means the ProtoBlock needs to include something like the ExecutionBid
242-
// will need to answer this question later.
240+
// TODO(EIP-7732): this should probably be obtained from the ProtoBlock instead of the DB
241+
// but this means the ProtoBlock needs to include something like the ExecutionBid
242+
// will need to answer this question later.
243243
let parent_block = chain
244244
.get_full_block(&beacon_block_root)?
245245
.ok_or_else(|| {
@@ -252,7 +252,7 @@ impl<T: BeaconChainTypes> GossipVerifiedEnvelope<T> {
252252
.signed_execution_payload_bid()?
253253
.message;
254254

255-
// TODO(gloas): Gossip rules for the beacon block contain the following:
255+
// TODO(EIP-7732): Gossip rules for the beacon block contain the following:
256256
// https://github.com/ethereum/consensus-specs/blob/master/specs/phase0/p2p-interface.md#beacon_block
257257
// [IGNORE] The block is not from a future slot (with a MAXIMUM_GOSSIP_CLOCK_DISPARITY allowance)
258258
// [IGNORE] The block is from a slot greater than the latest finalized slot
@@ -282,9 +282,9 @@ impl<T: BeaconChainTypes> GossipVerifiedEnvelope<T> {
282282
});
283283
}
284284

285-
// TODO(gloas): check these assumptions.. exactly what the most efficient way to verify the signatures
286-
// in this case isn't clear. There are questions about the proposer cache, the pubkey cache,
287-
// and so on.
285+
// TODO(EIP-7732): check these assumptions.. exactly what the most efficient way to verify the signatures
286+
// in this case isn't clear. There are questions about the proposer cache, the pubkey cache,
287+
// and so on.
288288

289289
// get the fork from the cache so we can verify the signature
290290
let block_slot = envelope.slot();
@@ -442,7 +442,7 @@ impl<T: BeaconChainTypes> IntoExecutionPendingEnvelope<T>
442442
chain: &Arc<BeaconChain<T>>,
443443
notify_execution_layer: NotifyExecutionLayer,
444444
) -> Result<ExecutionPendingEnvelope<T>, EnvelopeError> {
445-
// TODO(gloas): figure out how this should be refactored..
445+
// TODO(EIP-7732): figure out how this should be refactored..
446446
GossipVerifiedEnvelope::new(self, chain)?
447447
.into_execution_pending_envelope(chain, notify_execution_layer)
448448
}

consensus/state_processing/src/envelope_processing.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ use types::{
1111
Hash256, SignedExecutionPayloadEnvelope, Slot,
1212
};
1313

14-
// TODO(gloas): don't use this redefinition..
14+
// TODO(EIP-7732): don't use this redefinition..
1515
macro_rules! envelope_verify {
1616
($condition: expr, $result: expr) => {
1717
if !$condition {
@@ -118,7 +118,7 @@ pub fn envelope_processing<E: EthSpec>(
118118
) -> Result<(), EnvelopeProcessingError> {
119119
if verify_signatures.is_true() {
120120
// Verify Signed Envelope Signature
121-
// TODO(gloas): there is probably a more efficient way to do this..
121+
// TODO(EIP-7732): there is probably a more efficient way to do this..
122122
if !signed_envelope.verify_signature_with_state(&state, spec)? {
123123
return Err(EnvelopeProcessingError::BadSignature);
124124
}

consensus/types/src/signed_execution_payload_envelope.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ impl<E: EthSpec> SignedExecutionPayloadEnvelope<E> {
9595
///
9696
/// The `parent_state` is the post-state of the beacon block with
9797
/// block_root = self.message.beacon_block_root
98-
/// todo(gloas): maybe delete this function later
98+
/// TODO(EIP-7732): maybe delete this function later
9999
pub fn verify_signature_with_state(
100100
&self,
101101
parent_state: &BeaconState<E>,

0 commit comments

Comments
 (0)