Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt on "dangerous" operations #1069

Closed
FyreByrd opened this issue Feb 6, 2025 · 2 comments · Fixed by #1098
Closed

Prompt on "dangerous" operations #1069

FyreByrd opened this issue Feb 6, 2025 · 2 comments · Fixed by #1098
Labels
svelte-rewrite Issue for the S2 upgrade to Svelte

Comments

@FyreByrd
Copy link

FyreByrd commented Feb 6, 2025

When deleting a product there should be some sort of confirmation. There may be other places that need this extra layer too.
@FyreByrd FyreByrd added the svelte-rewrite Issue for the S2 upgrade to Svelte label Feb 13, 2025
@FyreByrd FyreByrd changed the title [Svelte] Prompt on "dangerous" operations Prompt on "dangerous" operations Feb 13, 2025
@FyreByrd
Copy link
Author

Operations that should be prompted on:

  • Delete Product

Should these be prompted on?

  • Cancel Rebuild/Republish
  • Archive Project
  • Changing store availability
  • Deleting a Group
  • Removing Authors/Reviewers

@FyreByrd
Copy link
Author

From @chrisvire

"Cancel - not a big deal ... can start another build
Archive - not destructive ... it can be un-archived
Changing store availability ... admin activity, can be easily reversed
Deleting a group ... admin activity, S1 prohibits group deletion if there are apps in it
Removing Authors/Reviewers ... they can be re-added"

@FyreByrd FyreByrd mentioned this issue Mar 31, 2025
Merged
@FyreByrd FyreByrd linked a pull request Mar 31, 2025 that will close this issue
Add prompt modal before deleting product #1098
Merged
@FyreByrd FyreByrd closed this as completed Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
svelte-rewrite Issue for the S2 upgrade to Svelte
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add prompt modal before deleting product sillsdev/appbuilder-portal
1 participant
@FyreByrd