No export buttons on saved dashboards, closes #71

Author: simonw

conftest.py

@@ -1,5 +1,6 @@
 import pytest
 from django.contrib.auth.models import Permission
+from django_sql_dashboard.models import Dashboard
 
 
 @pytest.fixture
@@ -16,3 +17,11 @@ def execute_sql_permission():
         content_type__model="dashboard",
         codename="execute_sql",
     )
+
+@pytest.fixture
+def saved_dashboard(dashboard_db):
+    dashboard = Dashboard.objects.create(
+        slug="test", title="Test dashboard", view_policy="public"
+    )
+    dashboard.queries.create(sql="select 11 + 33")
+    dashboard.queries.create(sql="select 22 + 55")

django_sql_dashboard/templates/django_sql_dashboard/widgets/default.html

@@ -13,7 +13,7 @@
   {% if result.truncated %}
     <p class="results-truncated">
       Results were truncated
-      {% if user_can_export_data %}
+      {% if user_can_export_data and not saved_dashboard %}
         <input
           class="btn"
           style="font-size: 0.6rem"
@@ -56,7 +56,7 @@
   </table>
   <details style="margin-top: 1em;"><summary style="font-size: 0.7em; margin-bottom: 0.5em; cursor: pointer;">Copy and export data</summary>
     <textarea id="copyable-{{ result.index }}" style="height: 10em">{{ result|sql_dashboard_tsv }}</textarea>
-    {% if user_can_export_data %}
+    {% if user_can_export_data and not saved_dashboard %}
       <div class="export-buttons">
         <input
           class="btn"

test_project/test_dashboard.py

@@ -4,19 +4,9 @@
 from bs4 import BeautifulSoup
 from django.core import signing
 
-from django_sql_dashboard.models import Dashboard
 from django_sql_dashboard.utils import SQL_SALT, is_valid_base64_json, sign_sql
 
 
-@pytest.fixture
-def saved_dashboard(dashboard_db):
-    dashboard = Dashboard.objects.create(
-        slug="test", title="Test dashboard", view_policy="public"
-    )
-    dashboard.queries.create(sql="select 11 + 33")
-    dashboard.queries.create(sql="select 22 + 55")
-
-
 def test_dashboard_submit_sql(admin_client, dashboard_db):
     # Test full flow of POST submitting new SQL, having it signed
     # and having it redirect to the results page

test_project/test_export.py

@@ -10,6 +10,14 @@ def test_export_requires_setting(admin_client, dashboard_db):
         assert response.status_code == 403
 
 
+def test_no_export_on_saved_dashboard(admin_client, dashboard_db, settings, saved_dashboard):
+    settings.DASHBOARD_ENABLE_FULL_EXPORT = True
+    response = admin_client.get("/dashboard/test/")
+    assert response.status_code == 200
+    assert b'<pre class="sql">select 22 + 55</pre>' in response.content
+    assert b'Export all as CSV' not in response.content
+
+
 def test_export_csv(admin_client, dashboard_db, settings):
     settings.DASHBOARD_ENABLE_FULL_EXPORT = True
     response = admin_client.post(