Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the options to add tags to the created resources #80

Open
threkk opened this issue Nov 21, 2022 · 3 comments
Open

Add the options to add tags to the created resources #80

threkk opened this issue Nov 21, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@threkk
Copy link

threkk commented Nov 21, 2022

Hello! I am looking into using s3-credentials for my projects. I use tags to identify resources in different ways, like how it was created or the project it belongs. I was wondering if there is planned support for adding tags to the resources created, or if you would be open for a contribution in that area.

@simonw simonw added the enhancement New feature or request label Nov 28, 2022
@simonw
Copy link
Owner

simonw commented Nov 28, 2022

This seems like a very good idea.

@simonw
Copy link
Owner

simonw commented Nov 28, 2022

One small catch: the s3-credentials create command may create a bunch of different resources:

  • An S3 bucket (or multiple buckets)
  • An IAM user
  • Maybe some policies too? I don't know if those are things that can have tags, but it wouldn't surprise me

As such, I wonder if having an option that says "tag everything created by this command" would be useful enough - what if people want to use different tags for the buckets and the user, for example?

So we could have an option --tag name value which applies to every resource - but then other options for --bucket-tag name value and --user-tag name value etc which you can use instead if you want different tags to different types of resource.

Or am I completely overthinking this? Maybe most people would be fine with tags applying to every type of created resource and people who really care about it can add the tags themselves.

@threkk
Copy link
Author

threkk commented Nov 28, 2022

In my case, the purpose of using tags is to find all the resources related to a project. From my perspective, just being able to add the same tags to all the resources is more than enough. However, I can see a case where people would like to use different tags for different resources. I would choose the most simple approach first, and wait to see if there is a need for higher granularity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants