Commit 04ac002
committed
fix(knowledge): make the conversation content hash collision-resistant
Greptile P1. The hash was `memory:{id}:{updatedAt}`, and updatedAt only has
millisecond resolution. Appends landing in the same millisecond as the value
already indexed hashed identically, so classifyExternalDoc called the
transcript unchanged and the new messages stayed out of the knowledge base
until some later write moved the clock.
messageCount closes the reported path — an append always increments it — and
approxBytes covers a same-count replacement. Both were already selected for
the listing, so neither costs an extra query. Mutation-checked: reverting to
the timestamp-only hash fails three tests.
Also switches the sim auth arm's line comment to TSDoc per the repo rule
(Greptile P2).1 parent 765adba commit 04ac002
3 files changed
Lines changed: 37 additions & 5 deletions
File tree
- apps/sim
- app/workspace/[workspaceId]/knowledge/[id]/components/add-connector-modal
- connectors/sim-conversations
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
249 | | - | |
| 249 | + | |
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
| |||
Lines changed: 25 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
215 | | - | |
| 215 | + | |
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
| |||
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
230 | 254 | | |
231 | 255 | | |
232 | 256 | | |
| |||
Lines changed: 11 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | | - | |
168 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
169 | 177 | | |
170 | 178 | | |
171 | 179 | | |
| |||
175 | 183 | | |
176 | 184 | | |
177 | 185 | | |
178 | | - | |
| 186 | + | |
179 | 187 | | |
180 | 188 | | |
181 | 189 | | |
| |||
0 commit comments