Adding more clear error message when tag is not known (#543)

* adding more clear error message when tag is not known
Signed-off-by: vsoch <[email protected]>

Author: vsoch

.github/workflows/main.yml

@@ -27,7 +27,7 @@ jobs:
         run: |
           export PATH="/usr/share/miniconda/bin:$PATH"
           source activate black
-          pip install black==20.8b1
+          pip install black
           black --check shpc
           
       - name: Check imports with pyflakes

CHANGELOG.md

@@ -14,6 +14,7 @@ and **Merged pull requests**. Critical items to know are:
 The versions coincide with releases on pip. Only major versions will be released as tags on Github.
 
 ## [0.0.x](https://github.com/singularityhub/singularity-hpc/tree/main) (0.0.x)
+ - better error message if container tag does not exist on update (0.0.52)
  - minimum version of spython required is 0.2.0 to support apptainer (0.0.51)
  - add support for TCL and LMOD default version, multiple variants (0.0.50)
  - refactor to "add" to generate a container.yaml first (0.0.49)

shpc/main/container/update/docker.py

@@ -37,14 +37,19 @@ def tags(self):
 
     def manifest(self, tag):
         url = "%s/manifest/%s:%s" % (self.apiroot, self.container_name, tag)
-        return self.get_request(url).json()
+        response = self.get_request(url)
+        return response.json()
 
     def digest(self, tag):
         url = "%s/digest/%s:%s" % (self.apiroot, self.container_name, tag)
-        response = self.get_request(url).text
+        response = self.get_request(url)
         if "could not parse reference" in response:
             logger.exit("Issue getting digest: %s" % response)
-        return self.get_request(url).text
+        if "MANIFEST_UNKNOWN" in response.text:
+            logger.exit(
+                f"The tag {tag} you provided is not known. Check that it and the container both exist."
+            )
+        return response.text
 
     def config(self):
         url = "%s/config/%s" % (self.apiroot, self.container_name)

shpc/version.py

@@ -2,7 +2,7 @@
 __copyright__ = "Copyright 2021-2022, Vanessa Sochat"
 __license__ = "MPL 2.0"
 
-__version__ = "0.0.51"
+__version__ = "0.0.52"
 AUTHOR = "Vanessa Sochat"
 NAME = "singularity-hpc"
 PACKAGE_URL = "https://github.com/singularityhub/singularity-hpc"