Skip to content

Commit 9d47e7b

Browse files
committed
Squashed 'src/secp256k1/' changes from 44c2452..21ffe4b
21ffe4b Merge bitcoin-core/secp256k1#1055: Prepare initial release e025ccd release: prepare for initial release 0.2.0 6d1784a build: add missing files to EXTRA_DIST 8c949f5 Merge bitcoin-core/secp256k1#1173: Don't use compute credits for now 13bf1b6 changelog: make order of change types match keepachangelog.com b1f992a doc: improve release process 7e5b226 Don't use compute credits for now ad39e2d build: change package version to 0.1.0-dev 5c789dc Merge bitcoin-core/secp256k1#1168: Replace deprecated context flags with NONE in benchmarks and tests d6dc0f4 tests: Switch to NONE contexts in module tests 0c8a5ca tests: Switch to NONE contexts in tests.c 86540e9 tests: add test for deprecated flags and rm them from run_context caa0ad6 group: add gej_eq_var 37ba744 tests: Switch to NONE contexts in exhaustive and ctime tests 8d7a9a8 benchmarks: Switch to NONE contexts 90618e9 doc: move CHANGELOG from doc/ to root directory e3f8477 Merge bitcoin-core/secp256k1#1126: API cleanup with respect to contexts 4386a23 examples: Switch to NONE contexts 7289b51 docs: Use doxygen style if and only if comment is user-facing e7d0185 docs: Get rid of "initialized for signing" terminology 0612636 docs: Tidy and improve docs about contexts and randomization e02d686 selftest: Expose in public API e383fbf selftest: Rename internal function to make name available for API d2c6d48 tests: Use new name of static context 53796d2 contexts: Rename static context 72fedf8 docs: Improve docs for static context 316ac76 contexts: Deprecate all context flags except SECP256K1_CONTEXT_NONE 477f02c Merge bitcoin-core/secp256k1#1165: gitignore: Add *.sage.py files autogenerated by sage [skip ci] 092be61 gitignore: Add *.sage.py files autogenerated by sage 1a553ee docs: Change signature "validation" to "verification" ee7341f docs: Never require a verification context 751c435 Merge bitcoin-core/secp256k1#1152: Update macOS image for CI 2286f80 Merge bitcoin-core/secp256k1#993: Enable non-experimental modules by default e40fd27 Merge bitcoin-core/secp256k1#1156: Followups to int128_struct arithmetic 99bd335 Make int128 overflow test use secp256k1_[ui]128_mul a8494b0 Use compute credits for macOS jobs 3afce0a Avoid signed overflow in MSVC AMR64 secp256k1_mul128 c0ae48c Update macOS image for CI 9b5f589 Heuristically decide whether to use int128_struct 63ff064 int128: Add test override for testing __(u)mulh on MSVC X64 f2b7e88 Add int128 randomized tests 6138d73 Merge bitcoin-core/secp256k1#1155: Add MSan CI jobs ddf2b29 Merge bitcoin-core/secp256k1#1000: Synthetic int128 type. 86e3b38 Merge bitcoin-core/secp256k1#1149: Remove usage of CHECK from non-test file 00a42b9 Add MSan CI job 44916ae Merge bitcoin-core/secp256k1#1147: ci: print env to allow reproducing the job outside of CI c2ee917 Merge bitcoin-core/secp256k1#1146: ci: prevent "-v/--version: not found" irrelevant error e13fae4 Merge bitcoin-core/secp256k1#1150: ci: always cat test_env.log a340d95 ci: add int128_struct tests dceaa1f int128: Tidy #includes of int128.h and int128_impl.h 2914bcc Simulated int128 type. 6a965b6 Remove usage of CHECK from non-test file 5c9f1a5 ci: always cat all logs_snippets 49ae843 ci: mostly prevent "-v/--version: not found" irrelevant error 4e54c03 ci: print env to allow reproducing the job outside of CI a43e982 Merge bitcoin-core/secp256k1#1144: Cleanup `.gitignore` file f5039cb Cleanup `.gitignore` file 798727a Revert "Add test logs to gitignore" 41e8704 build: Enable some modules by default 694ce8f Merge bitcoin-core/secp256k1#1131: readme: Misc improvements 88b0089 readme: Fix line break 78f5296 readme: Sell "no runtime dependencies" ef48f08 readme: Add IRC channel 9f8a13d Merge bitcoin-core/secp256k1#1128: configure: Remove pkgconfig macros again (reintroduced by mismerge) cabe085 configure: Remove pkgconfig macros again (reintroduced by mismerge) 3efeb9d Merge bitcoin-core/secp256k1#1121: config: Set preprocessor defaults for ECMULT_* config values 6a873cc Merge bitcoin-core/secp256k1#1122: tests: Randomize the context with probability 15/16 instead of 1/4 17065f4 tests: Randomize the context with probability 15/16 instead of 1/4 c27ae45 config: Remove basic-config.h da6514a config: Introduce DEBUG_CONFIG macro for debug output of config 63a3565 Merge bitcoin-core/secp256k1#1120: ecmult_gen: Skip RNG when creating blinding if no seed is available d0cf55e config: Set preprocessor defaults for ECMULT_* config values 55f8bc9 ecmult_gen: Improve comments about projective blinding 7a86955 ecmult_gen: Simplify code (no observable change) 4cc0b1b ecmult_gen: Skip RNG when creating blinding if no seed is available af65d30 Merge bitcoin-core/secp256k1#1116: build: Fix #include "..." paths to get rid of further -I arguments 40a3473 build: Fix #include "..." paths to get rid of further -I arguments 43756da Merge bitcoin-core/secp256k1#1115: Fix sepc256k1 -> secp256k1 typo in group.h 069aba8 Fix sepc256k1 -> secp256k1 typo in group.h accadc9 Merge bitcoin-core/secp256k1#1114: `_scratch_destroy`: move `VERIFY_CHECK` after invalid scrach space check cd47033 Merge bitcoin-core/secp256k1#1084: ci: Add MSVC builds 1827c9b scratch_destroy: move VERIFY_CHECK after invalid scrach space check 49e2acd configure: Improve rationale for WERROR_CFLAGS 8dc4b03 ci: Add a C++ job that compiles the public headers without -fpermissive 51f296a ci: Run persistent wineserver to speed up wine 3fb3269 ci: Add 32-bit MinGW64 build 9efc2e5 ci: Add MSVC builds 2be6ba0 configure: Convince autotools to work with MSVC's archiver lib.exe bd81f41 schnorrsig bench: Suppress a stupid warning in MSVC 09f3d71 configure: Add a few CFLAGS for MSVC 3b4f3d0 build: Reject C++ compilers in the preprocessor 1cc0941 configure: Don't abort if the compiler does not define __STDC__ cca8cbb configure: Output message when checking for valgrind 1a6be57 bench: Make benchmarks compile on MSVC git-subtree-dir: src/secp256k1 git-subtree-split: 21ffe4b
1 parent c41bfd1 commit 9d47e7b

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+2032
-1035
lines changed

.cirrus.yml

+105-54
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@ env:
2626
# Compile and run the tests
2727
EXAMPLES: yes
2828

29+
# https://cirrus-ci.org/pricing/#compute-credits
30+
credits_snippet: &CREDITS
31+
# Don't use any credits for now.
32+
use_compute_credits: false
33+
2934
cat_logs_snippet: &CAT_LOGS
3035
always:
3136
cat_tests_log_script:
@@ -36,7 +41,6 @@ cat_logs_snippet: &CAT_LOGS
3641
- cat valgrind_ctime_test.log || true
3742
cat_bench_log_script:
3843
- cat bench.log || true
39-
on_failure:
4044
cat_config_log_script:
4145
- cat config.log || true
4246
cat_test_env_script:
@@ -69,6 +73,7 @@ task:
6973
- env: {WIDEMUL: int64, RECOVERY: yes}
7074
- env: {WIDEMUL: int64, ECDH: yes, SCHNORRSIG: yes}
7175
- env: {WIDEMUL: int128}
76+
- env: {WIDEMUL: int128_struct}
7277
- env: {WIDEMUL: int128, RECOVERY: yes, SCHNORRSIG: yes}
7378
- env: {WIDEMUL: int128, ECDH: yes, SCHNORRSIG: yes}
7479
- env: {WIDEMUL: int128, ASM: x86_64}
@@ -107,65 +112,32 @@ task:
107112
<< : *CAT_LOGS
108113

109114
task:
110-
name: "x86_64: macOS Catalina"
115+
name: "arm64: macOS Ventura"
111116
macos_instance:
112-
image: catalina-base
117+
image: ghcr.io/cirruslabs/macos-ventura-base:latest
113118
env:
114119
HOMEBREW_NO_AUTO_UPDATE: 1
115120
HOMEBREW_NO_INSTALL_CLEANUP: 1
116-
# Cirrus gives us a fixed number of 12 virtual CPUs. Not that we even have that many jobs at the moment...
117-
MAKEFLAGS: -j13
121+
# Cirrus gives us a fixed number of 4 virtual CPUs. Not that we even have that many jobs at the moment...
122+
MAKEFLAGS: -j5
118123
matrix:
119124
<< : *ENV_MATRIX
125+
env:
126+
ASM: no
127+
WITH_VALGRIND: no
128+
CTIMETEST: no
120129
matrix:
121130
- env:
122-
CC: gcc-9
131+
CC: gcc
123132
- env:
124133
CC: clang
125-
# Update Command Line Tools
126-
# Uncomment this if the Command Line Tools on the CirrusCI macOS image are too old to brew valgrind.
127-
# See https://apple.stackexchange.com/a/195963 for the implementation.
128-
## update_clt_script:
129-
## - system_profiler SPSoftwareDataType
130-
## - touch /tmp/.com.apple.dt.CommandLineTools.installondemand.in-progress
131-
## - |-
132-
## PROD=$(softwareupdate -l | grep "*.*Command Line" | tail -n 1 | awk -F"*" '{print $2}' | sed -e 's/^ *//' | sed 's/Label: //g' | tr -d '\n')
133-
## # For debugging
134-
## - softwareupdate -l && echo "PROD: $PROD"
135-
## - softwareupdate -i "$PROD" --verbose
136-
## - rm /tmp/.com.apple.dt.CommandLineTools.installondemand.in-progress
137-
##
138-
brew_valgrind_pre_script:
139-
# Retry a few times because this tends to fail randomly.
140-
- for i in {1..5}; do brew update && break || sleep 15; done
141-
- brew config
142-
- brew tap LouisBrunner/valgrind
143-
# Fetch valgrind source but don't build it yet.
144-
- brew fetch --HEAD LouisBrunner/valgrind/valgrind
145-
brew_valgrind_cache:
146-
# This is $(brew --cellar valgrind) but command substition does not work here.
147-
folder: /usr/local/Cellar/valgrind
148-
# Rebuild cache if ...
149-
fingerprint_script:
150-
# ... macOS version changes:
151-
- sw_vers
152-
# ... brew changes:
153-
- brew config
154-
# ... valgrind changes:
155-
- git -C "$(brew --cache)/valgrind--git" rev-parse HEAD
156-
populate_script:
157-
# If there's no hit in the cache, build and install valgrind.
158-
- brew install --HEAD LouisBrunner/valgrind/valgrind
159-
brew_valgrind_post_script:
160-
# If we have restored valgrind from the cache, tell brew to create symlink to the PATH.
161-
# If we haven't restored from cached (and just run brew install), this is a no-op.
162-
- brew link valgrind
163134
brew_script:
164-
- brew install automake libtool gcc@9
135+
- brew install automake libtool gcc
165136
<< : *MERGE_BASE
166137
test_script:
167138
- ./ci/cirrus.sh
168139
<< : *CAT_LOGS
140+
<< : *CREDITS
169141

170142
task:
171143
name: "s390x (big-endian): Linux (Debian stable, QEMU)"
@@ -241,17 +213,63 @@ task:
241213
<< : *CAT_LOGS
242214

243215
task:
244-
name: "x86_64 (mingw32-w64): Windows (Debian stable, Wine)"
245216
<< : *LINUX_CONTAINER
246217
env:
247-
WRAPPER_CMD: wine64-stable
248-
SECP256K1_TEST_ITERS: 16
249-
HOST: x86_64-w64-mingw32
218+
WRAPPER_CMD: wine
250219
WITH_VALGRIND: no
251220
ECDH: yes
252221
RECOVERY: yes
253222
SCHNORRSIG: yes
254223
CTIMETEST: no
224+
matrix:
225+
- name: "x86_64 (mingw32-w64): Windows (Debian stable, Wine)"
226+
env:
227+
HOST: x86_64-w64-mingw32
228+
- name: "i686 (mingw32-w64): Windows (Debian stable, Wine)"
229+
env:
230+
HOST: i686-w64-mingw32
231+
<< : *MERGE_BASE
232+
test_script:
233+
- ./ci/cirrus.sh
234+
<< : *CAT_LOGS
235+
236+
task:
237+
<< : *LINUX_CONTAINER
238+
env:
239+
WRAPPER_CMD: wine
240+
WERROR_CFLAGS: -WX
241+
WITH_VALGRIND: no
242+
ECDH: yes
243+
RECOVERY: yes
244+
EXPERIMENTAL: yes
245+
SCHNORRSIG: yes
246+
CTIMETEST: no
247+
# Use a MinGW-w64 host to tell ./configure we're building for Windows.
248+
# This will detect some MinGW-w64 tools but then make will need only
249+
# the MSVC tools CC, AR and NM as specified below.
250+
HOST: x86_64-w64-mingw32
251+
CC: /opt/msvc/bin/x64/cl
252+
AR: /opt/msvc/bin/x64/lib
253+
NM: /opt/msvc/bin/x64/dumpbin -symbols -headers
254+
# Set non-essential options that affect the CLI messages here.
255+
# (They depend on the user's taste, so we don't want to set them automatically in configure.ac.)
256+
CFLAGS: -nologo -diagnostics:caret
257+
LDFLAGS: -XCClinker -nologo -XCClinker -diagnostics:caret
258+
matrix:
259+
- name: "x86_64 (MSVC): Windows (Debian stable, Wine)"
260+
- name: "x86_64 (MSVC): Windows (Debian stable, Wine, int128_struct)"
261+
env:
262+
WIDEMUL: int128_struct
263+
- name: "x86_64 (MSVC): Windows (Debian stable, Wine, int128_struct with __(u)mulh)"
264+
env:
265+
WIDEMUL: int128_struct
266+
CPPFLAGS: -DSECP256K1_MSVC_MULH_TEST_OVERRIDE
267+
- name: "i686 (MSVC): Windows (Debian stable, Wine)"
268+
env:
269+
HOST: i686-w64-mingw32
270+
CC: /opt/msvc/bin/x86/cl
271+
AR: /opt/msvc/bin/x86/lib
272+
NM: /opt/msvc/bin/x86/dumpbin -symbols -headers
255273
<< : *MERGE_BASE
256274
test_script:
257275
- ./ci/cirrus.sh
@@ -301,14 +319,39 @@ task:
301319
- ./ci/cirrus.sh
302320
<< : *CAT_LOGS
303321

322+
# Memory sanitizers
304323
task:
305-
name: "C++ -fpermissive"
306324
<< : *LINUX_CONTAINER
325+
name: "MSan"
307326
env:
308-
# ./configure correctly errors out when given CC=g++.
309-
# We hack around this by passing CC=g++ only to make.
310-
CC: gcc
311-
MAKEFLAGS: -j4 CC=g++ CFLAGS=-fpermissive\ -g
327+
ECDH: yes
328+
RECOVERY: yes
329+
SCHNORRSIG: yes
330+
CTIMETEST: no
331+
CC: clang
332+
SECP256K1_TEST_ITERS: 32
333+
ASM: no
334+
container:
335+
memory: 2G
336+
matrix:
337+
- env:
338+
CFLAGS: "-fsanitize=memory -g"
339+
- env:
340+
ECMULTGENPRECISION: 2
341+
ECMULTWINDOW: 2
342+
CFLAGS: "-fsanitize=memory -g -O3"
343+
<< : *MERGE_BASE
344+
test_script:
345+
- ./ci/cirrus.sh
346+
<< : *CAT_LOGS
347+
348+
task:
349+
name: "C++ -fpermissive (entire project)"
350+
<< : *LINUX_CONTAINER
351+
env:
352+
CC: g++
353+
CFLAGS: -fpermissive -g
354+
CPPFLAGS: -DSECP256K1_CPLUSPLUS_TEST_OVERRIDE
312355
WERROR_CFLAGS:
313356
ECDH: yes
314357
RECOVERY: yes
@@ -318,6 +361,14 @@ task:
318361
- ./ci/cirrus.sh
319362
<< : *CAT_LOGS
320363

364+
task:
365+
name: "C++ (public headers)"
366+
<< : *LINUX_CONTAINER
367+
test_script:
368+
- g++ -Werror include/*.h
369+
- clang -Werror -x c++-header include/*.h
370+
- /opt/msvc/bin/x64/cl.exe -c -WX -TP include/*.h
371+
321372
task:
322373
name: "sage prover"
323374
<< : *LINUX_CONTAINER

.gitignore

+1-3
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ schnorr_example
1313
*.so
1414
*.a
1515
*.csv
16-
!.gitignore
1716
*.log
1817
*.trs
18+
*.sage.py
1919

2020
Makefile
2121
configure
@@ -34,8 +34,6 @@ libtool
3434
*.lo
3535
*.o
3636
*~
37-
*.log
38-
*.trs
3937

4038
coverage/
4139
coverage.html

CHANGELOG.md

+28
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# Changelog
2+
3+
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
4+
5+
## [Unreleased]
6+
7+
## [0.2.0] - 2022-12-12
8+
9+
### Added
10+
- Added `secp256k1_selftest`, to be used in conjunction with `secp256k1_context_static`.
11+
12+
### Changed
13+
- Enabled modules schnorrsig, extrakeys and ECDH by default in `./configure`.
14+
15+
### Deprecated
16+
- Deprecated context flags `SECP256K1_CONTEXT_VERIFY` and `SECP256K1_CONTEXT_SIGN`. Use `SECP256K1_CONTEXT_NONE` instead.
17+
- Renamed `secp256k1_context_no_precomp` to `secp256k1_context_static`.
18+
19+
### ABI Compatibility
20+
21+
Since this is the first release, we do not compare application binary interfaces.
22+
However, there are unreleased versions of libsecp256k1 that are *not* ABI compatible with this version.
23+
24+
## [0.1.0] - 2013-03-05 to 2021-12-25
25+
26+
This version was in fact never released.
27+
The number was given by the build system since the introduction of autotools in Jan 2014 (ea0fe5a5bf0c04f9cc955b2966b614f5f378c6f6).
28+
Therefore, this version number does not uniquely identify a set of source files.

Makefile.am

+17-4
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,12 @@ noinst_HEADERS += src/precomputed_ecmult.h
4848
noinst_HEADERS += src/precomputed_ecmult_gen.h
4949
noinst_HEADERS += src/assumptions.h
5050
noinst_HEADERS += src/util.h
51+
noinst_HEADERS += src/int128.h
52+
noinst_HEADERS += src/int128_impl.h
53+
noinst_HEADERS += src/int128_native.h
54+
noinst_HEADERS += src/int128_native_impl.h
55+
noinst_HEADERS += src/int128_struct.h
56+
noinst_HEADERS += src/int128_struct_impl.h
5157
noinst_HEADERS += src/scratch.h
5258
noinst_HEADERS += src/scratch_impl.h
5359
noinst_HEADERS += src/selftest.h
@@ -58,7 +64,6 @@ noinst_HEADERS += src/hash_impl.h
5864
noinst_HEADERS += src/field.h
5965
noinst_HEADERS += src/field_impl.h
6066
noinst_HEADERS += src/bench.h
61-
noinst_HEADERS += src/basic-config.h
6267
noinst_HEADERS += contrib/lax_der_parsing.h
6368
noinst_HEADERS += contrib/lax_der_parsing.c
6469
noinst_HEADERS += contrib/lax_der_privatekey_parsing.h
@@ -87,7 +92,7 @@ endif
8792
endif
8893

8994
libsecp256k1_la_SOURCES = src/secp256k1.c
90-
libsecp256k1_la_CPPFLAGS = -I$(top_srcdir)/include -I$(top_srcdir)/src $(SECP_INCLUDES)
95+
libsecp256k1_la_CPPFLAGS = $(SECP_INCLUDES)
9196
libsecp256k1_la_LIBADD = $(SECP_LIBS) $(COMMON_LIB) $(PRECOMPUTED_LIB)
9297
libsecp256k1_la_LDFLAGS = -no-undefined -version-info $(LIB_VERSION_CURRENT):$(LIB_VERSION_REVISION):$(LIB_VERSION_AGE)
9398

@@ -112,7 +117,7 @@ TESTS =
112117
if USE_TESTS
113118
noinst_PROGRAMS += tests
114119
tests_SOURCES = src/tests.c
115-
tests_CPPFLAGS = -I$(top_srcdir)/src -I$(top_srcdir)/include $(SECP_INCLUDES) $(SECP_TEST_INCLUDES)
120+
tests_CPPFLAGS = $(SECP_INCLUDES) $(SECP_TEST_INCLUDES)
116121
if VALGRIND_ENABLED
117122
tests_CPPFLAGS += -DVALGRIND
118123
noinst_PROGRAMS += valgrind_ctime_test
@@ -211,7 +216,15 @@ maintainer-clean-local: clean-precomp
211216
clean-precomp:
212217
rm -f $(PRECOMP)
213218

214-
EXTRA_DIST = autogen.sh SECURITY.md
219+
EXTRA_DIST = autogen.sh CHANGELOG.md SECURITY.md
220+
EXTRA_DIST += doc/release-process.md doc/safegcd_implementation.md
221+
EXTRA_DIST += examples/EXAMPLES_COPYING
222+
EXTRA_DIST += sage/gen_exhaustive_groups.sage
223+
EXTRA_DIST += sage/gen_split_lambda_constants.sage
224+
EXTRA_DIST += sage/group_prover.sage
225+
EXTRA_DIST += sage/prove_group_implementations.sage
226+
EXTRA_DIST += sage/secp256k1_params.sage
227+
EXTRA_DIST += sage/weierstrass_prover.sage
215228

216229
if ENABLE_MODULE_ECDH
217230
include src/modules/ecdh/Makefile.am.include

README.md

+6-2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ libsecp256k1
22
============
33

44
[![Build Status](https://api.cirrus-ci.com/github/bitcoin-core/secp256k1.svg?branch=master)](https://cirrus-ci.com/github/bitcoin-core/secp256k1)
5+
![Dependencies: None](https://img.shields.io/badge/dependencies-none-success)
6+
[![irc.libera.chat #secp256k1](https://img.shields.io/badge/irc.libera.chat-%23secp256k1-success)](https://web.libera.chat/#secp256k1)
57

68
Optimized C library for ECDSA signatures and secret/public key operations on curve secp256k1.
79

@@ -15,6 +17,7 @@ Features:
1517
* Derandomized ECDSA (via RFC6979 or with a caller provided function.)
1618
* Very efficient implementation.
1719
* Suitable for embedded systems.
20+
* No runtime dependencies.
1821
* Optional module for public key recovery.
1922
* Optional module for ECDH key exchange.
2023
* Optional module for Schnorr signatures according to [BIP-340](https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki).
@@ -72,11 +75,12 @@ To compile optional modules (such as Schnorr signatures), you need to run `./con
7275

7376
Usage examples
7477
-----------
75-
Usage examples can be found in the [examples](examples) directory. To compile them you need to configure with `--enable-examples`.
78+
Usage examples can be found in the [examples](examples) directory. To compile them you need to configure with `--enable-examples`.
7679
* [ECDSA example](examples/ecdsa.c)
7780
* [Schnorr signatures example](examples/schnorr.c)
7881
* [Deriving a shared secret (ECDH) example](examples/ecdh.c)
79-
To compile the Schnorr signature and ECDH examples, you also need to configure with `--enable-module-schnorrsig` and `--enable-module-ecdh`.
82+
83+
To compile the Schnorr signature and ECDH examples, you also need to configure with `--enable-module-schnorrsig` and `--enable-module-ecdh`.
8084

8185
Test coverage
8286
-----------

build-aux/m4/bitcoin_secp.m4

+2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ AC_MSG_RESULT([$has_64bit_asm])
1010
])
1111

1212
AC_DEFUN([SECP_VALGRIND_CHECK],[
13+
AC_MSG_CHECKING([for valgrind support])
1314
if test x"$has_valgrind" != x"yes"; then
1415
CPPFLAGS_TEMP="$CPPFLAGS"
1516
CPPFLAGS="$VALGRIND_CPPFLAGS $CPPFLAGS"
@@ -21,6 +22,7 @@ if test x"$has_valgrind" != x"yes"; then
2122
#endif
2223
]])], [has_valgrind=yes; AC_DEFINE(HAVE_VALGRIND,1,[Define this symbol if valgrind is installed, and it supports the host platform])])
2324
fi
25+
AC_MSG_RESULT($has_valgrind)
2426
])
2527

2628
dnl SECP_TRY_APPEND_CFLAGS(flags, VAR)

0 commit comments

Comments
 (0)